From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Bandan Das" <bsd@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Qiuhao Li" <Qiuhao.Li@outlook.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, devel@daynix.com,
"Yan Vugenfirer" <yvugenfi@redhat.com>,
"Yuri Benditovich" <yuri.benditovich@daynix.com>,
"Sriram Yagnaraman" <sriram.yagnaraman@est.tech>
Subject: Re: [PATCH 00/31] Introduce igb
Date: Thu, 12 Jan 2023 11:36:15 +0100 [thread overview]
Message-ID: <0610e1a2-50e7-ea30-8ce3-92f8c83d3043@linaro.org> (raw)
In-Reply-To: <20230112095743.20123-1-akihiko.odaki@daynix.com>
On 12/1/23 10:57, Akihiko Odaki wrote:
> igb is a family of Intel's gigabit ethernet controllers. This series implements
> 82576 emulation in particular. You can see the last patch for the documentation.
>
> Note that there is another effort to bring 82576 emulation. This series was
> developed independently by Sriram Yagnaraman.
> https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04670.html
>
> Patch 1 - 16 are general improvements for e1000 and e1000e.
> Patch 17 - 18 are general improvements for e1000e test code.
> Patch 19 - 21 makes necessary modifications to existing files.
> Patch 22 starts off implementing igb emulation by copying e1000e code.
> Patch 23 renames things so that it won't collide with e1000e.
> Patch 24 makes building igb possible.
> Patch 25 actually transforms e1000e emulation code into igb emulation.
> Patch 26 - 27 makes modifications necessary for tests to existing files.
> Patch 28 copies e1000e test code.
> Patch 29 transforms e1000e test code into igb test code.
> Patch 30 adds ethtool test automation.
> Patch 31 adds the documentation.
>
> The main reason why this series is so huge is that the early part of this series
> includes general improvements for e1000e. They are placed before copying e1000e
> code so we won't need to duplicate those changes for both of e1000e and igb code
> later. As their utility do not depend on the igb implementation, they can be
> merged earlier if necessary.
You could post patches 1-23 as "e1000x cleanups (preliminary for IGB)"
then post the rest, using the 'Based-on:' tag referring to the first
series cover letter.
I remember looking at the various e1000x cleanups independently, all
packed in the same series makes review context-switching cheaper for
me, so thanks.
Not really related to IGB but since you touched MDIO/MII/PHY files,
it would be great if we unify the MDIO as a qbus and the various PHYs
as qdevs, so boards could use any/multiple PHYs. We had 2 or 3 attempts
to do that in the past but none got merged.
prev parent reply other threads:[~2023-01-12 10:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 9:57 [PATCH 00/31] Introduce igb Akihiko Odaki
2023-01-12 9:57 ` [PATCH 01/31] e1000e: Fix the code style Akihiko Odaki
2023-01-12 10:39 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 02/31] hw/net: Add more MII definitions Akihiko Odaki
2023-01-12 9:57 ` [PATCH 03/31] fsl_etsec: Use hw/net/mii.h Akihiko Odaki
2023-01-12 10:40 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 04/31] e1000: " Akihiko Odaki
2023-01-12 10:42 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 05/31] e1000: Mask registers when writing Akihiko Odaki
2023-01-12 9:57 ` [PATCH 06/31] e1000e: " Akihiko Odaki
2023-01-12 9:57 ` [PATCH 07/31] e1000: Use more constant definitions Akihiko Odaki
2023-01-12 10:45 ` Philippe Mathieu-Daudé
2023-01-13 0:02 ` BALATON Zoltan
2023-01-12 9:57 ` [PATCH 08/31] e1000e: " Akihiko Odaki
2023-01-12 9:57 ` [PATCH 09/31] e1000: Use memcpy to intialize registers Akihiko Odaki
2023-01-12 9:57 ` [PATCH 10/31] e1000e: " Akihiko Odaki
2023-01-12 9:57 ` [PATCH 11/31] e1000e: Remove pending interrupt flags Akihiko Odaki
2023-01-12 9:57 ` [PATCH 12/31] e1000e: Improve software reset Akihiko Odaki
2023-01-12 9:57 ` [PATCH 13/31] e1000: Configure ResettableClass Akihiko Odaki
2023-01-12 10:49 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 14/31] e1000e: " Akihiko Odaki
2023-01-12 10:49 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 15/31] e1000e: Introduce e1000_rx_desc_union Akihiko Odaki
2023-01-12 9:57 ` [PATCH 16/31] e1000e: Set MII_ANER_NWAY Akihiko Odaki
2023-01-12 10:51 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 17/31] tests/qtest/e1000e-test: Fix the code style Akihiko Odaki
2023-01-12 10:51 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 18/31] tests/qtest/libqos/e1000e: Remove duplicate register definitions Akihiko Odaki
2023-01-12 10:52 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 19/31] hw/net/net_tx_pkt: Introduce net_tx_pkt_get_eth_hdr Akihiko Odaki
2023-01-12 9:57 ` [PATCH 20/31] pcie: Introduce pcie_sriov_num_vfs Akihiko Odaki
2023-01-12 10:53 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 21/31] e1000: Split header files Akihiko Odaki
2023-01-12 11:00 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 22/31] igb: Copy e1000e code Akihiko Odaki
2023-01-12 9:57 ` [PATCH 23/31] igb: Rename identifiers Akihiko Odaki
2023-01-12 9:57 ` [PATCH 24/31] igb: Build igb Akihiko Odaki
2023-01-12 9:57 ` [PATCH 25/31] igb: Transform to 82576 implementation Akihiko Odaki
2023-01-12 9:57 ` [PATCH 26/31] tests/qtest/e1000e-test: Fabricate ethernet header Akihiko Odaki
2023-01-12 9:57 ` [PATCH 27/31] tests/qtest/libqos/e1000e: Export macreg functions Akihiko Odaki
2023-01-12 9:57 ` [PATCH 28/31] tests/qtest/libqos/igb: Copy e1000e code Akihiko Odaki
2023-01-12 9:57 ` [PATCH 29/31] tests/qtest/libqos/igb: Transform to igb tests Akihiko Odaki
2023-01-12 9:57 ` [PATCH 30/31] tests/avocado: Add igb test Akihiko Odaki
2023-01-12 9:57 ` [PATCH 31/31] docs/system/devices/igb: Add igb documentation Akihiko Odaki
2023-01-12 10:36 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0610e1a2-50e7-ea30-8ce3-92f8c83d3043@linaro.org \
--to=philmd@linaro.org \
--cc=Qiuhao.Li@outlook.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=alxndr@bu.edu \
--cc=bleal@redhat.com \
--cc=bsd@redhat.com \
--cc=crosa@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=devel@daynix.com \
--cc=dmitry.fleytman@gmail.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sriram.yagnaraman@est.tech \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=yuri.benditovich@daynix.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).