From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Re: [PULL v2] Block layer patches
Date: Sat, 12 Sep 2020 14:27:24 +0200 [thread overview]
Message-ID: <06214b2c-adc7-1e3b-a15f-fe3c16ff0983@redhat.com> (raw)
In-Reply-To: <480db253-9aa4-39c3-592f-bc5cfea1997b@redhat.com>
On 10/09/2020 00.09, Eric Blake wrote:
> On 9/9/20 4:55 PM, Peter Maydell wrote:
>
>>
>> This fails 'make check' on NetBSD and OpenBSD:
>>
>> ./check: line 47: realpath: command not found
>> ./check: line 60: /common.env: No such file or directory
>> check: failed to source common.env (make sure the qemu-iotests are run
>> from tests/qemu-iotests in the build tree)
>> gmake: *** [/home/qemu/qemu-test.vcb7nz/src/tests/Makefile.include:144:
>> check-block] Error 1
>
> BSD has 'readlink -f' (and so does coreutils on Linux), which does the
> same thing as the Linux-only realpath.
Seems like readlink -f does not work on macOS:
https://cirrus-ci.com/task/5735398972325888?command=main#L7038
Any ideas what to use instead?
Peter, why did this slip through your merge tests, do you still skip the
iotests there?
Thomas
next prev parent reply other threads:[~2020-09-12 12:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 11:53 [PULL v2] Block layer patches Kevin Wolf
2020-09-09 21:55 ` Peter Maydell
2020-09-09 22:09 ` Eric Blake
2020-09-10 9:13 ` Kevin Wolf
2020-09-10 11:54 ` Max Reitz
2020-09-12 12:27 ` Thomas Huth [this message]
2020-09-12 18:38 ` Peter Maydell
2020-09-14 5:36 ` Thomas Huth
-- strict thread matches above, loose matches on Subject: below --
2020-07-09 12:17 Kevin Wolf
2020-07-10 15:41 ` Peter Maydell
2020-07-10 16:05 ` Eric Blake
2020-07-10 16:14 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06214b2c-adc7-1e3b-a15f-fe3c16ff0983@redhat.com \
--to=thuth@redhat.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).