From: Richard Henderson <richard.henderson@linaro.org>
To: Weiwei Li <liweiwei@iscas.ac.cn>,
palmer@dabbelt.com, alistair.francis@wdc.com,
bin.meng@windriver.com, qemu-riscv@nongnu.org,
qemu-devel@nongnu.org
Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com, ardxwe@gmail.com
Subject: Re: [PATCH v3 2/6] target/riscv: hardwire mstatus.FS to zero when enable zfinx
Date: Fri, 7 Jan 2022 12:48:23 -0800 [thread overview]
Message-ID: <06256f71-8d17-a9ab-b45d-5bb1034453f3@linaro.org> (raw)
In-Reply-To: <20220107112749.981-3-liweiwei@iscas.ac.cn>
On 1/7/22 3:27 AM, Weiwei Li wrote:
> @@ -342,6 +342,11 @@ static void mark_fs_dirty(DisasContext *ctx)
> {
> TCGv tmp;
>
> + /* hardwire mstatus.FS to zero when enable zfinx */
> + if (ctx->ext_zfinx) {
> + return;
> + }
> +
> if (ctx->mstatus_fs != MSTATUS_FS) {
This should also test RVF.
Finally, there needs to be a change to write_misa -- MSTATUS_FS needs to be cleared when
RVF is disabled.
r~
next prev parent reply other threads:[~2022-01-07 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 11:27 [PATCH v3 0/6] support subsets of Float-Point in Integer Registers extensions Weiwei Li
2022-01-07 11:27 ` [PATCH v3 1/6] target/riscv: add cfg properties for zfinx, zdinx and zhinx{min} Weiwei Li
2022-01-07 11:27 ` [PATCH v3 2/6] target/riscv: hardwire mstatus.FS to zero when enable zfinx Weiwei Li
2022-01-07 20:48 ` Richard Henderson [this message]
2022-01-08 1:17 ` Weiwei Li
2022-01-07 11:27 ` [PATCH v3 3/6] target/riscv: add support for zfinx Weiwei Li
2022-01-07 11:27 ` [PATCH v3 4/6] target/riscv: add support for zdinx Weiwei Li
2022-01-07 20:54 ` Richard Henderson
2022-01-08 1:14 ` Weiwei Li
2022-01-07 11:27 ` [PATCH v3 5/6] target/riscv: add support for zhinx/zhinxmin Weiwei Li
2022-01-07 11:27 ` [PATCH v3 6/6] target/riscv: expose zfinx, zdinx, zhinx{min} properties Weiwei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06256f71-8d17-a9ab-b45d-5bb1034453f3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=ardxwe@gmail.com \
--cc=bin.meng@windriver.com \
--cc=lazyparser@gmail.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=wangjunqiang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).