From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Qemu-devel] [PATCH 5/5] [debug] some logging
Date: Fri, 11 Jan 2019 09:33:40 -0600 [thread overview]
Message-ID: <06341f73-6063-8cc3-dc1a-e5022ef2e032@redhat.com> (raw)
In-Reply-To: <20190111093116.17188-6-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On 1/11/19 3:31 AM, Gerd Hoffmann wrote:
> ---
> hw/vfio/display.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/hw/vfio/display.c b/hw/vfio/display.c
> index a3a710b3ee..96b5474243 100644
> --- a/hw/vfio/display.c
> +++ b/hw/vfio/display.c
> @@ -42,6 +42,8 @@ static void vfio_display_edid_link_up(void *opaque)
> VFIOPCIDevice *vdev = opaque;
> VFIODisplay *dpy = vdev->dpy;
>
> + fprintf(stderr, "%s:\n", __func__);
Why fprintf() instead of trace points?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-11 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 9:31 [Qemu-devel] [PATCH 0/5] vfio/display: add edid support Gerd Hoffmann
2019-01-11 9:31 ` [Qemu-devel] [PATCH 1/5] vfio: update kernel headers Gerd Hoffmann
2019-01-11 15:32 ` Eric Blake
2019-01-14 6:15 ` Gerd Hoffmann
2019-01-11 9:31 ` [Qemu-devel] [PATCH 2/5] vfio/display: add edid support Gerd Hoffmann
2019-01-17 22:27 ` Alex Williamson
2019-01-11 9:31 ` [Qemu-devel] [PATCH 3/5] vfio/display: add xres + yres properties Gerd Hoffmann
2019-01-17 22:27 ` Alex Williamson
2019-01-11 9:31 ` [Qemu-devel] [PATCH 4/5] vfio/display: delay link up event Gerd Hoffmann
2019-01-17 22:27 ` Alex Williamson
2019-01-11 9:31 ` [Qemu-devel] [PATCH 5/5] [debug] some logging Gerd Hoffmann
2019-01-11 15:33 ` Eric Blake [this message]
2019-01-14 12:37 ` Gerd Hoffmann
2019-01-13 17:12 ` [Qemu-devel] [PATCH 0/5] vfio/display: add edid support no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06341f73-6063-8cc3-dc1a-e5022ef2e032@redhat.com \
--to=eblake@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).