From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org,
Radoslaw Biernacki <rad@semihalf.com>,
Peter Maydell <peter.maydell@linaro.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Xiaojuan Yang <yangxiaojuan@loongson.cn>,
Song Gao <gaosong@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH] hw: Simplify calls to pci_nic_init_nofail()
Date: Thu, 29 Jun 2023 23:15:16 +0200 [thread overview]
Message-ID: <06397069-f1bb-fe79-1ffc-7f13e3fc7e5e@linaro.org> (raw)
In-Reply-To: <509ddf59-b401-41c5-099a-0acbf2c94f11@redhat.com>
On 29/6/23 16:58, Thomas Huth wrote:
> On 29/06/2023 15.47, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
>>
>> On 29/6/23 14:54, Thomas Huth wrote:
>>> pci_nic_init_nofail() calls qemu_find_nic_model(), and this function
>>> sets nd->model = g_strdup(default_model) if it has not been initialized
>>> yet. So we don't have to set nd->model to the default_nic in the
>>> calling sites.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>> hw/arm/sbsa-ref.c | 8 +-------
>>> hw/arm/virt.c | 8 +-------
>>> hw/loongarch/virt.c | 8 +-------
>>> hw/mips/loongson3_virt.c | 8 +-------
>>> hw/xtensa/virt.c | 8 +-------
>>> 5 files changed, 5 insertions(+), 35 deletions(-)
> ...
>> This remind me of a branch from end of April with this
>> unfinished patch, did we already discuss this together?
>
> No, I haven't seen your patch yet, neither we talked about it. I came up
> with the idea for my patch on my own after looking at certain spots in
> the code. But I guess you could easily rebase your patch on top of mine
> in case you want to finish it ;-)
Yeah sure, I was just wondering :)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-06-29 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 12:54 [PATCH] hw: Simplify calls to pci_nic_init_nofail() Thomas Huth
2023-06-29 13:47 ` Philippe Mathieu-Daudé
2023-06-29 14:58 ` Thomas Huth
2023-06-29 21:15 ` Philippe Mathieu-Daudé [this message]
2023-06-30 6:35 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06397069-f1bb-fe79-1ffc-7f13e3fc7e5e@linaro.org \
--to=philmd@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=gaosong@loongson.cn \
--cc=jasowang@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=thuth@redhat.com \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).