From: David Hildenbrand <david@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qiaonuohan@cn.fujitsu.com,
Peter Maydell <peter.maydell@linaro.org>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] dump: fix kdump to work over non-aligned blocks
Date: Fri, 26 Aug 2022 12:07:25 +0200 [thread overview]
Message-ID: <063e98e9-a10f-5b38-d1dc-63f29c7ebfbb@redhat.com> (raw)
In-Reply-To: <CAJ+F1CJs-s2v1ivdwmwkS86=JU+rrqrov8HZiyEzFGDE-injnQ@mail.gmail.com>
On 26.08.22 12:02, Marc-André Lureau wrote:
> Hi
>
>
> On Fri, Aug 26, 2022 at 2:01 PM David Hildenbrand <david@redhat.com
> <mailto:david@redhat.com>> wrote:
>
> On 25.08.22 15:21, marcandre.lureau@redhat.com
> <mailto:marcandre.lureau@redhat.com> wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com
> <mailto:marcandre.lureau@redhat.com>>
> >
> > Rewrite get_next_page() to work over non-aligned blocks. When it
> > encounters non aligned addresses, it will allocate a zero-page and try
> > to fill it.
>
> Could we simplify by using one global helper page (or caller provided
> page) and avoiding the allocation/freeing?
>
>
> I don't think that makes a big difference, but certainly doable.
If we're using one central page, I guess we'd have to pass "flag_sync =
true" to write_cache() in case that page is used. Or we simply specify
on the single global page in there and force a sync. Changes would be
limited to get_next_page() and write_cache() then.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-08-26 10:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 13:21 [PATCH 0/2] Fix dumping in kdump format with non-aligned memory marcandre.lureau
2022-08-25 13:21 ` [PATCH 1/2] dump: simplify a bit kdump get_next_page() marcandre.lureau
2022-08-26 9:45 ` David Hildenbrand
2022-08-26 9:56 ` Marc-André Lureau
2022-08-26 9:58 ` David Hildenbrand
2022-08-25 13:21 ` [PATCH 2/2] dump: fix kdump to work over non-aligned blocks marcandre.lureau
2022-08-25 13:34 ` Peter Maydell
2022-08-25 13:38 ` Marc-André Lureau
2022-08-26 9:57 ` David Hildenbrand
2022-08-26 10:02 ` Marc-André Lureau
2022-08-26 10:07 ` David Hildenbrand [this message]
2022-08-26 10:10 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063e98e9-a10f-5b38-d1dc-63f29c7ebfbb@redhat.com \
--to=david@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qiaonuohan@cn.fujitsu.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).