* [PATCH] tests/qtest: Pass down do_connect param in qtest_init_with_env()
@ 2025-04-22 12:04 Xiaoyao Li
2025-04-22 13:20 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Xiaoyao Li @ 2025-04-22 12:04 UTC (permalink / raw)
To: Fabiano Rosas, Laurent Vivier; +Cc: Paolo Bonzini, qemu-devel, Steve Sistare
The @do_connect parameter of qtest_init_with_env() is not used. Fix it
by passing it down to qtest_init_with_env_and_capabilities() instead of
hard coding a true.
Fixes: 5357ef823a1f ("tests/qtest: defer connection")
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
tests/qtest/libqtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index fad307d125aa..518710909c3e 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -597,7 +597,7 @@ QTestState *qtest_init_with_env_and_capabilities(const char *var,
QTestState *qtest_init_with_env(const char *var, const char *extra_args,
bool do_connect)
{
- return qtest_init_with_env_and_capabilities(var, extra_args, NULL, true);
+ return qtest_init_with_env_and_capabilities(var, extra_args, NULL, do_connect);
}
QTestState *qtest_init(const char *extra_args)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tests/qtest: Pass down do_connect param in qtest_init_with_env()
2025-04-22 12:04 [PATCH] tests/qtest: Pass down do_connect param in qtest_init_with_env() Xiaoyao Li
@ 2025-04-22 13:20 ` Philippe Mathieu-Daudé
2025-04-22 14:48 ` Steven Sistare
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-22 13:20 UTC (permalink / raw)
To: Xiaoyao Li, Fabiano Rosas, Laurent Vivier
Cc: Paolo Bonzini, qemu-devel, Steve Sistare
On 22/4/25 14:04, Xiaoyao Li wrote:
> The @do_connect parameter of qtest_init_with_env() is not used. Fix it
> by passing it down to qtest_init_with_env_and_capabilities() instead of
> hard coding a true.
>
> Fixes: 5357ef823a1f ("tests/qtest: defer connection")
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> tests/qtest/libqtest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/qtest: Pass down do_connect param in qtest_init_with_env()
2025-04-22 13:20 ` Philippe Mathieu-Daudé
@ 2025-04-22 14:48 ` Steven Sistare
2025-04-22 15:13 ` Xiaoyao Li
0 siblings, 1 reply; 4+ messages in thread
From: Steven Sistare @ 2025-04-22 14:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Xiaoyao Li, Fabiano Rosas,
Laurent Vivier
Cc: Paolo Bonzini, qemu-devel, Vladimir Sementsov-Ogievskiy
On 4/22/2025 9:20 AM, Philippe Mathieu-Daudé wrote:
> On 22/4/25 14:04, Xiaoyao Li wrote:
>> The @do_connect parameter of qtest_init_with_env() is not used. Fix it
>> by passing it down to qtest_init_with_env_and_capabilities() instead of
>> hard coding a true.
>>
>> Fixes: 5357ef823a1f ("tests/qtest: defer connection")
>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>> ---
>> tests/qtest/libqtest.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
This is the same bug that Vladimir fixed:
https://lore.kernel.org/qemu-devel/20250410162250.329941-1-vsementsov@yandex-team.ru/
- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/qtest: Pass down do_connect param in qtest_init_with_env()
2025-04-22 14:48 ` Steven Sistare
@ 2025-04-22 15:13 ` Xiaoyao Li
0 siblings, 0 replies; 4+ messages in thread
From: Xiaoyao Li @ 2025-04-22 15:13 UTC (permalink / raw)
To: Steven Sistare, Philippe Mathieu-Daudé, Fabiano Rosas,
Laurent Vivier
Cc: Paolo Bonzini, qemu-devel, Vladimir Sementsov-Ogievskiy
On 4/22/2025 10:48 PM, Steven Sistare wrote:
> On 4/22/2025 9:20 AM, Philippe Mathieu-Daudé wrote:
>> On 22/4/25 14:04, Xiaoyao Li wrote:
>>> The @do_connect parameter of qtest_init_with_env() is not used. Fix it
>>> by passing it down to qtest_init_with_env_and_capabilities() instead of
>>> hard coding a true.
>>>
>>> Fixes: 5357ef823a1f ("tests/qtest: defer connection")
>>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>>> ---
>>> tests/qtest/libqtest.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>
>
> This is the same bug that Vladimir fixed:
>
> https://lore.kernel.org/qemu-devel/20250410162250.329941-1-
> vsementsov@yandex-team.ru/
Thanks for the info!
> - Steve
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-22 15:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22 12:04 [PATCH] tests/qtest: Pass down do_connect param in qtest_init_with_env() Xiaoyao Li
2025-04-22 13:20 ` Philippe Mathieu-Daudé
2025-04-22 14:48 ` Steven Sistare
2025-04-22 15:13 ` Xiaoyao Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).