[Qemu-devel] Re: Re: [PATCH v2 6/6] Pass cpu speed into SM BIOS.

["Sebastian Herbszt" <herbszt@gmx.de>]

Gleb Natapov wrote:
>>>> This is the incorrect frequency for a QEMU guest.  I'm not sure why 
>>>> this  is included.  What does passing the frequency give us?
>>>>
>>> This is included for two reasons. First one is to demonstrate that
>>> proposed interface is extensible. Second is that Micrisoft SVVP test  
>>> requires this info (and much more) to be set in SMBIOS tables.
>>
>> Can you elaborate a bit on the "and much more" part? Is this the stuff
>> described in "SMBIOS "Designed for Windows" Logo Requirements" at
>> http://www.microsoft.com/whdc/system/platform/firmware/SMBIOS.mspx ?
>>
> I think yes. There is Microsoft test suit that test SMBIOS
> implementation. Running it on bochs bios results in a couple of errors.

Could you maybe post those errors on the bochs mailing list?

> Some fields cannot be empty. Some bits should be set. Most things can be
> fixed without qemu help, but for CPU speed we need to ask qemu.

What about computing the frequency in rombios?

>>> Using real HW value seams to be better than just provide some default one.
>>
>> What downside does using a default value have? On the upside this patch would
>> not be needed.
>>
>>
> What value do you propose? Without knowing how Windows uses it we can't
> say what are the downsides.

- Sebastian