From: Thomas Huth <thuth@redhat.com>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: "Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Radoslaw Biernacki" <rad@semihalf.com>,
"Troy Lee" <leetroy@gmail.com>,
"Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Beraldo Leal" <bleal@redhat.com>,
kvm@vger.kernel.org, "Joel Stanley" <joel@jms.id.au>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
"Cédric Le Goater" <clg@kaod.org>, "Paul Durrant" <paul@xen.org>,
"Eric Auger" <eric.auger@redhat.com>,
"David Woodhouse" <dwmw2@infradead.org>,
qemu-arm@nongnu.org,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Jamin Lin" <jamin_lin@aspeedtech.com>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Leif Lindholm" <quic_llindhol@quicinc.com>
Subject: Re: [PATCH v2 2/9] tests/avocado: apply proper skipUnless decorator
Date: Mon, 12 Aug 2024 12:21:24 +0200 [thread overview]
Message-ID: <0658b06b-024e-484c-861d-1b1ef3ce7888@redhat.com> (raw)
In-Reply-To: <20240806173119.582857-3-crosa@redhat.com>
On 06/08/2024 19.31, Cleber Rosa wrote:
> Commit 9b45cc993 added many cases of skipUnless for the sake of
> organizing flaky tests. But, Python decorators *must* follow what
s/follow/directly precede/ ?
Apart from that:
Reviewed-by: Thomas Huth <thuth@redhat.com>
> they decorate, so the newlines added should *not* exist there.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/avocado/boot_linux_console.py | 1 -
> tests/avocado/intel_iommu.py | 1 -
> tests/avocado/linux_initrd.py | 1 -
> tests/avocado/machine_aspeed.py | 2 --
> tests/avocado/machine_mips_malta.py | 2 --
> tests/avocado/machine_rx_gdbsim.py | 2 --
> tests/avocado/reverse_debugging.py | 4 ----
> tests/avocado/smmu.py | 1 -
> 8 files changed, 14 deletions(-)
next prev parent reply other threads:[~2024-08-12 10:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 17:31 [PATCH v2 0/9] Bump Avocado to 103.0 LTS and update tests for compatibility and new features Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 1/9] Bump avocado to 103.0 Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 2/9] tests/avocado: apply proper skipUnless decorator Cleber Rosa
2024-08-06 19:28 ` Philippe Mathieu-Daudé
2024-08-12 10:21 ` Thomas Huth [this message]
2024-08-06 17:31 ` [PATCH v2 3/9] tests/avocado: add cdrom permission related tests Cleber Rosa
2024-08-16 14:46 ` Thomas Huth
2024-08-06 17:31 ` [PATCH v2 4/9] tests/avocado: machine aarch64: standardize location and RO access Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 5/9] tests/avocado: simplify parameters on fetch_asset with name only Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 6/9] tests/avocado/boot_xen.py: fetch kernel during test setUp() Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 7/9] tests/avocado/tuxrun_baselines.py: use Avocado's zstd support Cleber Rosa
2024-08-06 18:20 ` Marcin Juszkiewicz
2024-08-07 17:26 ` Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 8/9] tests/avocado/machine_aarch64_sbsaref.py: allow for rw usage of image Cleber Rosa
2024-08-06 19:30 ` Philippe Mathieu-Daudé
2024-08-07 17:26 ` Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 9/9] Avocado tests: allow for parallel execution of tests Cleber Rosa
2024-08-12 10:17 ` Thomas Huth
2024-08-15 14:08 ` Cleber Rosa
2024-08-15 16:02 ` Thomas Huth
2024-08-15 22:35 ` Richard Henderson
2024-08-06 18:20 ` [PATCH v2 0/9] Bump Avocado to 103.0 LTS and update tests for compatibility and new features Marcin Juszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0658b06b-024e-484c-861d-1b1ef3ce7888@redhat.com \
--to=thuth@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=aurelien@aurel32.net \
--cc=bleal@redhat.com \
--cc=clg@kaod.org \
--cc=crosa@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eric.auger@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kvm@vger.kernel.org \
--cc=leetroy@gmail.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=paul@xen.org \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=sriram.yagnaraman@ericsson.com \
--cc=steven_lee@aspeedtech.com \
--cc=wainersm@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).