From: "bauerchen(陈蒙蒙)" <bauerchen@tencent.com>
To: kraxel <kraxel@redhat.com>
Cc: hdegoede <hdegoede@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: Re: is just a wrong function name of libusb_get_port_number? request for a review of the bug fix(Internet mail)
Date: Fri, 3 Apr 2020 08:50:19 +0000 [thread overview]
Message-ID: <0679a6d48df44a6e8d2b635dfb0cc566@tencent.com> (raw)
In-Reply-To: 20200403081902.tvjuv6gel3iucub7@sirius.home.kraxel.org
[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]
OK，thanks, I will try .
________________________________
Bauer
From: kraxel<mailto:kraxel@redhat.com>
Date: 2020-04-03 16:19
To: bauerchen(陈蒙蒙)<mailto:bauerchen@tencent.com>
CC: qemu-devel<mailto:qemu-devel@nongnu.org>; hdegoede<mailto:hdegoede@redhat.com>
Subject: Re: is just a wrong function name of libusb_get_port_number? request for a review of the bug fix(Internet mail)
On Fri, Apr 03, 2020 at 07:05:13AM +0000, bauerchen(陈蒙蒙) wrote:
> thanks, but my libusbx version is libusbx-1.0.15-4.el7.x86_64 ,
> I can find libusb_get_port_numbers function in libusb-1.0.so.0 but find libusb_get_port_number
>
> [root@t]# strings /lib64/libusb-1.0.so.0 |grep libusb_get_port_number
> libusb_get_port_number
> [root@t]#
kraxel@sirius ~# grep libusb_get_port_number /usr/include/libusb-1.0/libusb.h
uint8_t LIBUSB_CALL libusb_get_port_number(libusb_device *dev);
int LIBUSB_CALL libusb_get_port_numbers(libusb_device *dev, uint8_t* port_numbers, int port_numbers_len);
LIBUSB_DEPRECATED_FOR(libusb_get_port_numbers)
So libusb_get_port_numbers replaces libusb_get_port_number, seems you have an
old version which hasn't yet libusb_get_port_numbers.
On old version qemu should fallback to libusb_get_port_path, but maybe the
version #ifdef is wrong so this doesn't work properly for some versions ...
According to my /usr/include/libusb-1.0/libusb.h libusb >= 1.0.16 declares
LIBUSB_API_VERSION >= 0x01000102, so that looks ok. Hmm, not sure what is
going on here. In any case the libusb_get_port_path fallback code path
should work.
cheers,
Gerd
[-- Attachment #2: Type: text/html, Size: 3008 bytes --]
prev parent reply other threads:[~2020-04-03 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 11:47 is just a wrong function name of libusb_get_port_number? request for a review of the bug fix bauerchen(陈蒙蒙)
2020-04-03 6:50 ` kraxel
2020-04-03 7:05 ` Re: is just a wrong function name of libusb_get_port_number? request for a review of the bug fix(Internet mail) bauerchen(陈蒙蒙)
2020-04-03 8:19 ` kraxel
2020-04-03 8:50 ` bauerchen(陈蒙蒙) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0679a6d48df44a6e8d2b635dfb0cc566@tencent.com \
--to=bauerchen@tencent.com \
--cc=hdegoede@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).