From: Thomas Huth <thuth@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH v2] fuzz: refine the ide/ahci fuzzer configs
Date: Wed, 20 Jan 2021 16:45:24 +0100 [thread overview]
Message-ID: <067d9d9d-f77b-f7ff-67b0-0ac995568ea7@redhat.com> (raw)
In-Reply-To: <20210120152211.109782-1-alxndr@bu.edu>
On 20/01/2021 16.22, Alexander Bulekov wrote:
> Disks work differently depending on the x86 machine type (SATA vs PATA).
> Additionally, we should fuzz the atapi code paths, which might contain
> vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and
> cdrom generic-fuzzer configs for both the pc (PATA) and q35 (SATA)
> machine types.
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>
> v2: Fix ide-hd -> ide-cd in the ahci-atapi config
>
> tests/qtest/fuzz/generic_fuzz_configs.h | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
> index 7fed035345..aa4c03f1ae 100644
> --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> @@ -85,10 +85,28 @@ const generic_fuzz_config predefined_configs[] = {
> .objects = "intel-hda",
> },{
> .name = "ide-hd",
> + .args = "-machine pc -nodefaults "
> + "-drive file=null-co://,if=none,format=raw,id=disk0 "
> + "-device ide-hd,drive=disk0",
> + .objects = "*ide*",
> + },{
> + .name = "ide-atapi",
> + .args = "-machine pc -nodefaults "
> + "-drive file=null-co://,if=none,format=raw,id=disk0 "
> + "-device ide-cd,drive=disk0",
> + .objects = "*ide*",
> + },{
> + .name = "ahci-hd",
> .args = "-machine q35 -nodefaults "
> "-drive file=null-co://,if=none,format=raw,id=disk0 "
> "-device ide-hd,drive=disk0",
> - .objects = "ahci*",
> + .objects = "*ahci*",
> + },{
> + .name = "ahci-atapi",
> + .args = "-machine q35 -nodefaults "
> + "-drive file=null-co://,if=none,format=raw,id=disk0 "
> + "-device ide-cd,drive=disk0",
> + .objects = "*ahci*",
> },{
> .name = "floppy",
> .args = "-machine pc -nodefaults -device floppy,id=floppy0 "
>
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-01-20 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 15:22 [PATCH v2] fuzz: refine the ide/ahci fuzzer configs Alexander Bulekov
2021-01-20 15:45 ` Thomas Huth [this message]
2021-01-20 17:09 ` Darren Kenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=067d9d9d-f77b-f7ff-67b0-0ac995568ea7@redhat.com \
--to=thuth@redhat.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).