Re: [Qemu-devel] [PATCH v3 9/9] target/ppc: replace AVR* macros with Vsr* macros

[Richard Henderson <richard.henderson@linaro.org>]

On 12/20/18 8:31 AM, Mark Cave-Ayland wrote:
> Now that the VMX and VSR register sets have been combined, the same macros can
> be used to access both AVR and VSR field members.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  target/ppc/int_helper.c | 38 +++++++++++++-------------------------
>  target/ppc/internal.h   |  4 ++++
>  2 files changed, 17 insertions(+), 25 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


>  #if defined(HOST_WORDS_BIGENDIAN)
> +#define HI_IDX 0
> +#define LO_IDX 1
>  #define VsrB(i) u8[i]
>  #define VsrH(i) u16[i]
>  #define VsrW(i) u32[i]
>  #define VsrD(i) u64[i]

Since this is in internal.h, we can use it elsewhere than just helpers.  E.g.
if you sort some patches earlier, you could use it in get_avr64 instead of ifdefs.


r~