From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA032C7EE23 for ; Sat, 25 Feb 2023 18:39:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVzRZ-0006mQ-Fe; Sat, 25 Feb 2023 13:38:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVzRY-0006lG-5H for qemu-devel@nongnu.org; Sat, 25 Feb 2023 13:38:48 -0500 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVzRV-0001rC-Mb for qemu-devel@nongnu.org; Sat, 25 Feb 2023 13:38:47 -0500 Received: by mail-pj1-x1035.google.com with SMTP id h17-20020a17090aea9100b0023739b10792so2434410pjz.1 for ; Sat, 25 Feb 2023 10:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RuFK10TSCPDhZ5zBq/WmlGFcwRrVgs2wOo2eDDnr2Bs=; b=mzId2zgTauI/9PoxrdAKlNXH9F+3gCng7qE6pVQZ8rF7L7iSKMWBdMQzzmIRtJvSwn ia8tSvqqzFz7hab65FDgXPB/rGNUkcm/I1dIVXB5Vw1o3uIUyTg2aFunrrTLsBKiUSSm 1wdSI+xMWAaFMXc5vaZtypkDO39C0M74Mg2/WJ5yM3wCIli6qnewazOANQqfTZNVl6gR zSJXw2jcou2LLq32WRKKxBhuA/hy/c29vwT+v4ausvHrOaPRxkTgtQ17lnc9ji/pm34c cjBilkyB4u3oYZj0436Xd7tdmbxc3florVEjPo11yyBltZtXaoKnwOBDSEases5VaAi3 iZFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RuFK10TSCPDhZ5zBq/WmlGFcwRrVgs2wOo2eDDnr2Bs=; b=QrbDgydwjUxh1cVlhU4IcU2mOY3Pm/Ad/0OlHQHBnsbOUerE9cktUXjRz8+ZZar4mA OilpVQIFHCQ2jtHvG+96+kDL2JtW4Owq0ZTnjX8fCDM3Wk8PXPQYsrthgX0/c6hqOCKO ecL11QQzxLJUyV/pFnbklZIRQLuP/eGxW5jITLclOaI4SxWYGTuGYEaN2Zad8mvTdIIk 5HhE3j0CWobqF5GQahhzK5AUPmlLOj8Xe7rYWIg7WpLK9dv+0f1tQoe8ej7QVygExiI6 VRyV7HAB7SFZjE8GSmdcAfRSuK5MUmi+xSreTdGFW7S2ydfZqU55yj4dOqj/7rdwLrKU 28AQ== X-Gm-Message-State: AO0yUKWJa/yFCfpjGWj1fNaOehLYJlc8VJFhQKGr1hXgC3ZESv8KDLfO rmkYCvbAsNhDTUSNyUn0ut3ZxA== X-Google-Smtp-Source: AK7set8wQcIJ8UuO+AqvO7ae+BIRRdn3FkZgmbn1ORaB79pMOAsJWL5bHTMLMCxaBqsQ8OD7L3d8RA== X-Received: by 2002:a17:902:f687:b0:19a:a43c:41aa with SMTP id l7-20020a170902f68700b0019aa43c41aamr20247109plg.66.1677350323998; Sat, 25 Feb 2023 10:38:43 -0800 (PST) Received: from [192.168.6.128] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id j4-20020a170902c08400b001978e84753asm1576942pld.65.2023.02.25.10.38.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Feb 2023 10:38:43 -0800 (PST) Message-ID: <06a53b69-b58c-168f-7e7d-bf7d028ebccd@linaro.org> Date: Sat, 25 Feb 2023 08:38:37 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 74/76] tracing: remove transform.py To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com References: <20230225091427.1817156-1-richard.henderson@linaro.org> <20230225091427.1817156-75-richard.henderson@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/25/23 00:22, Daniel Henrique Barboza wrote: > Richard, > > Not sure if I forgot or missed something but this patch breaks my build as follows: > > $  make -j >   GIT     ui/keycodemapdb tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc > [1/885] Generating trace/trace-hw_hyperv.c with a custom command > FAILED: trace/trace-hw_hyperv.c > /usr/bin/python3 ../scripts/tracetool.py --backend=log --group=hw_hyperv --format=c > /home/danielhb/work/qemu/hw/hyperv/trace-events trace/trace-hw_hyperv.c > Traceback (most recent call last): >   File "/home/danielhb/work/qemu/build/../scripts/tracetool.py", line 19, in >     from tracetool import error_write, out, out_open >   File "/home/danielhb/work/qemu/scripts/tracetool/__init__.py", line 21, in >     import tracetool.transform > ModuleNotFoundError: No module named 'tracetool.transform' I saw the same thing on gitlab, but not on my laptop. Weird. > It seems that tracetool.py is still referring transform. This fixes the build > for me: > > $ git diff > diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py > index 5393c7fc5c..c361815bc1 100644 > --- a/scripts/tracetool/__init__.py > +++ b/scripts/tracetool/__init__.py > @@ -18,7 +18,6 @@ > >  import tracetool.format >  import tracetool.backend > -import tracetool.transform I also removed some code below that used these symbols; they themselves appear to be unused. r~