From: Richard Henderson <richard.henderson@linaro.org>
To: "Christian Borntraeger" <borntraeger@de.ibm.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
peter.maydell@linaro.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
qemu-devel@nongnu.org, "Willian Rampazzo" <willianr@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>
Subject: Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds
Date: Fri, 16 Jul 2021 09:02:24 -0700 [thread overview]
Message-ID: <06abfcd6-d33e-cc66-cace-4211276d133e@linaro.org> (raw)
In-Reply-To: <79129f00-6b82-e2e9-8e1e-5ffdfad02b84@de.ibm.com>
On 7/16/21 8:31 AM, Christian Borntraeger wrote:
>
>
> On 16.07.21 16:58, Christian Borntraeger wrote:
>>
>>
>> On 16.07.21 16:51, Richard Henderson wrote:
>>> On 7/16/21 4:28 AM, Christian Borntraeger wrote:
>>>> --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now"
>>
>> Full configure line is
>>
>> ../configure --prefix=/usr --libdir=/usr/lib64 --sysconfdir=/etc
>> --interp-prefix=/usr/qemu-%M --localstatedir=/var --libexecdir=/usr/libexec
>> --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now" --extra-cflags="-O2 -g
>> -fPIE -DPIE" --enable-werror --disable-strip --disable-rbd
>> --disable-fdt --disable-xen --enable-kvm --enable-trace-backend=log
>> --iasl=false --target-list=s390x-softmmu,i386-softmmu,x86_64-softmmu,s390x-linux-user
>>
>>
>>> FWIW, -pie should not be buried in --extra-ldflags, but as --enable-pie on the normal
>>> configure line.
>>
>> I picked that from the configure script of an older fedora qemu src rpm some years ago
>> and I use that to do build checks.
>
> using enable-pie instead of burying it in the ldflags seems to fix things.
> Question is do we still care about this regression?
I don't think so. Your incorrect ldflags (appropriate for the main executable, perhaps)
was leaking into the shared library plugins, where -shared and -pie conflict.
r~
next prev parent reply other threads:[~2021-07-16 16:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 12:26 [PULL for 6.1 00/40] testing and plugin updates Alex Bennée
2021-07-12 12:26 ` [PULL 01/40] Jobs based on custom runners: documentation and configuration placeholder Alex Bennée
2021-07-12 12:26 ` [PULL 02/40] Jobs based on custom runners: build environment docs and playbook Alex Bennée
2021-07-12 12:26 ` [PULL 03/40] Jobs based on custom runners: docs and gitlab-runner setup playbook Alex Bennée
2021-07-12 12:26 ` [PULL 04/40] Jobs based on custom runners: add job definitions for QEMU's machines Alex Bennée
2021-07-12 12:26 ` [PULL 05/40] tests/tcg: also disable the signals test for plugins Alex Bennée
2021-07-12 12:26 ` [PULL 06/40] build: validate that system capstone works before using it Alex Bennée
2021-07-12 12:26 ` [PULL 07/40] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run Alex Bennée
2021-07-12 12:26 ` [PULL 08/40] cirrus: delete FreeBSD and macOS jobs Alex Bennée
2021-07-12 12:26 ` [PULL 09/40] hw/usb/ccid: remove references to NSS Alex Bennée
2021-07-12 12:26 ` [PULL 10/40] tests/docker: don't use BUILDKIT in GitLab either Alex Bennée
2021-07-12 12:26 ` [PULL 11/40] tests/docker: use project specific container registries Alex Bennée
2021-07-12 12:26 ` [PULL 12/40] tests/docker: use explicit docker.io registry Alex Bennée
2021-07-12 12:26 ` [PULL 13/40] tests/docker: remove FEATURES env var from templates Alex Bennée
2021-07-12 12:26 ` [PULL 14/40] tests/docker: fix sorting in package lists Alex Bennée
2021-07-12 12:26 ` [PULL 15/40] tests/docker: fix mistakes in centos " Alex Bennée
2021-07-12 12:26 ` [PULL 16/40] tests/docker: fix mistakes in fedora package list Alex Bennée
2021-07-12 12:26 ` [PULL 17/40] tests/docker: fix mistakes in ubuntu package lists Alex Bennée
2021-07-12 12:26 ` [PULL 18/40] tests/docker: remove mingw packages from Fedora Alex Bennée
2021-07-12 12:26 ` [PULL 19/40] tests/docker: expand centos8 package list Alex Bennée
2021-07-12 12:26 ` [PULL 20/40] tests/docker: expand fedora " Alex Bennée
2021-07-12 12:26 ` [PULL 21/40] tests/docker: expand ubuntu1804 " Alex Bennée
2021-07-12 12:26 ` [PULL 22/40] tests/docker: expand ubuntu2004 " Alex Bennée
2021-07-12 12:26 ` [PULL 23/40] tests/docker: expand opensuse-leap " Alex Bennée
2021-07-12 12:26 ` [PULL 24/40] tests/vm: update NetBSD to 9.2 Alex Bennée
2021-07-12 12:26 ` [PULL 25/40] tests/vm: update openbsd to release 6.9 Alex Bennée
2021-07-12 12:26 ` [PULL 26/40] tests/tcg: make test-mmap a little less aggressive Alex Bennée
2021-07-12 12:26 ` [PULL 27/40] plugins: fix-up handling of internal hostaddr for 32 bit Alex Bennée
2021-07-12 12:26 ` [PULL 28/40] meson.build: move TCG plugin summary output Alex Bennée
2021-07-12 12:26 ` [PULL 29/40] configure: don't allow plugins to be enabled for a non-TCG build Alex Bennée
2021-07-12 12:26 ` [PULL 30/40] configure: add an explicit static and plugins check Alex Bennée
2021-07-12 12:26 ` [PULL 31/40] configure: stop user enabling plugins on Windows for now Alex Bennée
2021-07-12 12:26 ` [PULL 32/40] tcg/plugins: enable by default for most TCG builds Alex Bennée
2021-07-16 6:54 ` Christian Borntraeger
2021-07-16 11:28 ` Christian Borntraeger
2021-07-16 13:16 ` Alex Bennée
2021-07-16 14:51 ` Richard Henderson
2021-07-16 14:58 ` Christian Borntraeger
2021-07-16 15:31 ` Christian Borntraeger
2021-07-16 16:02 ` Richard Henderson [this message]
2021-07-12 12:26 ` [PULL 33/40] contrib/plugins: enable -Wall for building plugins Alex Bennée
2021-07-12 12:26 ` [PULL 34/40] contrib/plugins: add execlog to log instruction execution and memory access Alex Bennée
2021-07-12 12:26 ` [PULL 35/40] docs/devel: tcg-plugins: add execlog plugin description Alex Bennée
2021-07-12 12:26 ` [PULL 36/40] plugins: Added a new cache modelling plugin Alex Bennée
2021-07-12 12:26 ` [PULL 37/40] plugins/cache: Enable cache parameterization Alex Bennée
2021-07-12 12:26 ` [PULL 38/40] plugins/cache: Added FIFO and LRU eviction policies Alex Bennée
2021-07-12 12:26 ` [PULL 39/40] docs/devel: Added cache plugin to the plugins docs Alex Bennée
2021-07-12 12:26 ` [PULL 40/40] MAINTAINERS: Added myself as a reviewer for TCG Plugins Alex Bennée
2021-07-12 12:56 ` [PULL for 6.1 00/40] testing and plugin updates Alex Bennée
2021-07-12 14:51 ` Alex Bennée
2021-07-12 22:19 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06abfcd6-d33e-cc66-cace-4211276d133e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=erdnaxe@crans.org \
--cc=f4bug@amsat.org \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).