From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Andrew Jones <drjones@redhat.com>, Alexander Graf <agraf@csgraf.de>
Subject: Re: [PATCH 6/6] target/arm: Support PAuth extension for hvf
Date: Sun, 6 Feb 2022 11:26:45 +1100 [thread overview]
Message-ID: <06bc9314-2f23-4a0d-4ae5-8695a93778a2@linaro.org> (raw)
In-Reply-To: <20220204165506.2846058-7-peter.maydell@linaro.org>
On 2/5/22 03:55, Peter Maydell wrote:
> Currently we don't allow guests under hvf to use the PAuth extension,
> because we didn't have any special code to handle that, and therefore
> in arm_cpu_pauth_finalize() we will sanitize the ID_AA64ISAR1 value
> the guest sees to clear the PAuth related fields.
>
> Add support for this in the same way that KVM does it, by defaulting
> to "PAuth enabled" if the host CPU has it and allowing the user to
> disable it via '-cpu pauth=no' on the command line.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> target/arm/cpu64.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
Currently not a problem in practice because M1 doesn't support PAuth, so the ID fields are
already clear. However, it is a confusing difference to kvm, and presumably some future
Apple chip will enable PAuth.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-02-06 0:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 16:55 [PATCH 0/6] target/arm: -cpu host/max KVM and HVF fixes Peter Maydell
2022-02-04 16:55 ` [PATCH 1/6] target/arm: Move '-cpu host' code to cpu64.c Peter Maydell
2022-02-06 0:11 ` Richard Henderson
2022-02-04 16:55 ` [PATCH 2/6] target/arm: Use aarch64_cpu_register() for 'host' CPU type Peter Maydell
2022-02-06 0:14 ` Richard Henderson
2022-02-04 16:55 ` [PATCH 3/6] target/arm: Make KVM -cpu max exactly like -cpu host Peter Maydell
2022-02-06 0:16 ` Richard Henderson
2022-02-04 16:55 ` [PATCH 4/6] target/arm: Unindent unnecessary else-clause Peter Maydell
2022-02-06 0:20 ` Richard Henderson
2022-02-04 16:55 ` [PATCH 5/6] target/arm: Fix '-cpu max' for HVF Peter Maydell
2022-02-06 0:21 ` Richard Henderson
2022-02-04 16:55 ` [PATCH 6/6] target/arm: Support PAuth extension for hvf Peter Maydell
2022-02-06 0:26 ` Richard Henderson [this message]
2022-02-06 10:41 ` Peter Maydell
2022-02-06 18:46 ` [PATCH 0/6] target/arm: -cpu host/max KVM and HVF fixes Philippe Mathieu-Daudé via
2022-02-09 10:30 ` Andrew Jones
2022-02-09 12:49 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bc9314-2f23-4a0d-4ae5-8695a93778a2@linaro.org \
--to=richard.henderson@linaro.org \
--cc=agraf@csgraf.de \
--cc=drjones@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).