From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org, no-reply@patchew.org, suhang16@mails.ucas.ac.cn
Cc: stefanha@gmail.com, jim@groklearning.com, famz@redhat.com,
joel@jms.id.au
Subject: Re: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case
Date: Wed, 4 Apr 2018 10:45:57 -0500 [thread overview]
Message-ID: <06bd734b-3b48-ab51-3425-4cbb2dfe3bc0@redhat.com> (raw)
In-Reply-To: <152276983686.1416.16137563993301721352@71c20359a636>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On 04/03/2018 10:37 AM, no-reply@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/2: Implement .hex file loader...
> ERROR: braces {} are necessary for all arms of this statement
> #220: FILE: hw/core/loader.c:1463:
> + } while (++hex_blob != end);
> [...]
False positive; this is a known bug in checkpatch.pl, and there is even
a patch proposed to resolve it, but no one has incorporated the patch yet:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05232.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-04-04 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 15:30 [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case Su Hang
2018-04-03 15:30 ` [Qemu-devel] [PATCH 1/2] Implement .hex file loader Su Hang
2018-04-03 15:30 ` [Qemu-devel] [PATCH 2/2] Add QTest testcase for the Hex File Loader Su Hang
2018-04-03 15:37 ` [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case no-reply
2018-04-04 15:45 ` Eric Blake [this message]
2018-04-04 16:00 ` Su Hang
-- strict thread matches above, loose matches on Subject: below --
2018-04-03 15:17 Su Hang
2018-04-03 15:25 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bd734b-3b48-ab51-3425-4cbb2dfe3bc0@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=no-reply@patchew.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=suhang16@mails.ucas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).