From: Thomas Huth <thuth@redhat.com>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] qemu-doc: Rework the network options chapter to make "-net" less prominent
Date: Wed, 28 Mar 2018 08:03:06 +0200 [thread overview]
Message-ID: <06bda6b5-f496-50d8-de4b-6f417d037908@redhat.com> (raw)
In-Reply-To: <7a3f63c9-7778-31f0-518a-5872c41c09c3@redhat.com>
On 28.03.2018 04:59, Jason Wang wrote:
>
>
> On 2018年03月27日 21:16, Thomas Huth wrote:
>>>> # launch vde switch
>>>> vde_switch -F -sock /tmp/myswitch
>>>> # launch QEMU instance
>>>> -qemu-system-i386 linux.img -net nic -net vde,sock=/tmp/myswitch
>>>> +qemu-system-i386 linux.img -nic vde,sock=/tmp/myswitch
>>> I think we should use -netdev here?
>> I've had that in the original version of this patch, but Paolo suggested
>> to use -nic instead since this is more "user-friendly":
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg05258.html
>>
>> I personally don't mind whether we use "-netdev" or "-nic" in the
>> examples, as long as we finally get rid of "-net" there...
>
> Right.
>
>> Please let me
>> know which way you prefer, so I can respin the patch again if necessary.
>>
>> Thomas
>>
>
> But I think we should be consistent: in your patch some "-net" was
> replaced by "-nic", but others were replaced by "-netdev".
These are *examples*, and I think it's good to give the users examples
for both ways of specifying a network connection. I'd really like to
avoid that people think that -nic is the only way of specifying such a
device, since you might not be able to configure all properties of the
NIC this way. On the other hand, -device + -netdev is really way more to
type, so we should also not only show this kind of examples. Thus a
mixture between both ways sounds like the right solution to me. But if
you disagree, let me know, then I can rework the patch again to either
only use -nic or only use -netdev in the examples.
Thomas
next prev parent reply other threads:[~2018-03-28 6:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 12:20 [Qemu-devel] [PATCH v3] qemu-doc: Rework the network options chapter to make "-net" less prominent Thomas Huth
2018-03-26 16:42 ` Thomas Huth
2018-03-27 13:02 ` Jason Wang
2018-03-27 13:01 ` Jason Wang
2018-03-27 13:16 ` Thomas Huth
2018-03-28 2:59 ` Jason Wang
2018-03-28 6:03 ` Thomas Huth [this message]
2018-03-28 6:27 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bda6b5-f496-50d8-de4b-6f417d037908@redhat.com \
--to=thuth@redhat.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).