From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>,
Alexander Graf <agraf@csgraf.de>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH] hvf: arm: Fix hvf_sysreg_read_cp() call
Date: Fri, 2 Aug 2024 17:53:54 +0200 [thread overview]
Message-ID: <06c4aad6-8c1d-4474-b3b6-4cc9065edc33@linaro.org> (raw)
In-Reply-To: <20240802-hvf-v1-1-e2c0292037e5@daynix.com>
On 2/8/24 10:37, Akihiko Odaki wrote:
> Commit 05b8d7249109 ("hvf: arm: Do not advance PC when raising an
> exception") changed val from uint64_t to a pointer to uint64_t in
> hvf_sysreg_read(), but didn't change its hvf_sysreg_read_cp() call.
>
> Fixes: 05b8d7249109 ("hvf: arm: Do not advance PC when raising an exception")
Not 05b8d7249109 but e9e640148c.
Fixes: e9e640148c ("hvf: arm: Raise an exception for sysreg by default")
Updating description:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> target/arm/hvf/hvf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
next prev parent reply other threads:[~2024-08-02 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 8:37 [PATCH] hvf: arm: Fix hvf_sysreg_read_cp() call Akihiko Odaki
2024-08-02 8:44 ` Peter Maydell
2024-08-02 9:50 ` Richard Henderson
2024-08-02 15:53 ` Philippe Mathieu-Daudé [this message]
2024-08-02 23:30 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06c4aad6-8c1d-4474-b3b6-4cc9065edc33@linaro.org \
--to=philmd@linaro.org \
--cc=agraf@csgraf.de \
--cc=akihiko.odaki@daynix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).