From: Richard Henderson <rth@twiddle.net>
To: tony.nguyen@bt.com, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com
Subject: Re: [Qemu-devel] [PATCH 2/4] memory: Single byte swap along the I/O path
Date: Wed, 17 Jul 2019 07:24:18 -0700 [thread overview]
Message-ID: <06dca0ee-a556-d09b-7f13-6938b5a1f74f@twiddle.net> (raw)
In-Reply-To: <1563343596429.3033@bt.com>
On 7/16/19 11:06 PM, tony.nguyen@bt.com wrote:
> +++ b/include/exec/poison.h
> @@ -38,7 +38,6 @@
> #pragma GCC poison TARGET_HAS_BFLT
> #pragma GCC poison TARGET_NAME
> #pragma GCC poison TARGET_SUPPORTS_MTTCG
> -#pragma GCC poison TARGET_WORDS_BIGENDIAN
You can't do this. This is here for a very good reason, to avoid letting
target-specific values creep into code that is compiled once, for all targets.
This means that you'll need to either move MO_TE out of memop.h or perhaps
conditionalize it upon NEED_CPU_H.
I would like to see this patch broken up into smaller bits. Convert one
interface at a time, pushing the use of MemOp further down the stack. At
present it's hard to review.
r~
next prev parent reply other threads:[~2019-07-17 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 5:57 [Qemu-devel] [PATCH 0/4] Invert Endian bit in SPARCv9 MMU TTE tony.nguyen
2019-07-17 6:04 ` [Qemu-devel] [PATCH 1/4] tcg: TCGMemOp is now accelerator independent MemOp tony.nguyen
2019-07-17 14:04 ` Richard Henderson
2019-07-17 6:06 ` [Qemu-devel] [PATCH 2/4] memory: Single byte swap along the I/O path tony.nguyen
2019-07-17 10:08 ` Paolo Bonzini
2019-07-17 14:24 ` Richard Henderson [this message]
2019-07-17 6:08 ` [Qemu-devel] [PATCH 3/4] cputlb: Byte swap memory transaction attribute tony.nguyen
2019-07-17 14:29 ` Richard Henderson
2019-07-17 6:10 ` [Qemu-devel] [PATCH 4/4] target/sparc: sun4u Invert Endian TTE bit tony.nguyen
2019-07-21 19:50 ` Mark Cave-Ayland
2019-07-17 10:09 ` [Qemu-devel] [PATCH 0/4] Invert Endian bit in SPARCv9 MMU TTE Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06dca0ee-a556-d09b-7f13-6938b5a1f74f@twiddle.net \
--to=rth@twiddle.net \
--cc=atar4qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tony.nguyen@bt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).