Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: use scsi_create_task()

[Paolo Bonzini <pbonzini@redhat.com>]

On 06/07/2017 23:37, John Snow wrote:
> 
> On 06/07/2017 02:35 AM, Marc-André Lureau wrote:
>> The function does the same initialization, and matches with
>> scsi_free_scsi_task() usage, and qemu doesn't need to know the
>> allocator details.
>>
> 
> Happy month-iversary for this patch!
> 
> Yeah, uh, we should probably not be reaching into this structure
> ourselves, huh? I had to look up the iscsi source just to confirm that
> we /were/ doing the right thing, but now we won't have to worry about it.
> 
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Reviewed-by: John Snow <jsnow@redhat.com>
> 
> This should be care of... Ronnie, Paolo, and Peter Lieven?

The only snag:

commit 0c6e3bffb353f141bb68fe822e3ea9df5eee8c8c
Author: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date:   Thu Dec 18 09:20:17 2014 -0800

    SCSI: scsi_create_task must set task->cdb_size
    
    We forgot to set task->cdb_size which means all tasks we create with this
    function becomes test unit ready :-(
    
    Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>


At least RHEL7 has libiscsi-1.9.0.

Paolo