From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB3CC433E0 for ; Mon, 8 Jun 2020 15:54:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B4A0206A4 for ; Mon, 8 Jun 2020 15:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JlM9G4Th" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B4A0206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiK6X-0002YT-Ro for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 11:54:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiK5q-0001zm-7A for qemu-devel@nongnu.org; Mon, 08 Jun 2020 11:53:46 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:33371 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiK5p-0006F0-0G for qemu-devel@nongnu.org; Mon, 08 Jun 2020 11:53:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591631624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bRX5cd4PSmZjLbnmv/zvE9vd3m0ZlZ29ehF+5prf8SQ=; b=JlM9G4ThMgtnNOFDmW+Vt7A2oIuVgNwRVhDMnjWMeJD+hbG6NqIFKkGhb2AxeDTDhz/yjD E6p4Is3rGxNrrMRcXkaDmxyAZy6iPLoWgsV1p0RTz2Pi95oGwp5T9hs8VtHeXmCdEZAoel cfDcNy3MxDxpcq1fTnlwJhN532E5DWg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-SRJa3ttXPUWroRqppdodWA-1; Mon, 08 Jun 2020 11:53:37 -0400 X-MC-Unique: SRJa3ttXPUWroRqppdodWA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26ACC8015CB; Mon, 8 Jun 2020 15:53:35 +0000 (UTC) Received: from [10.3.113.22] (ovpn-113-22.phx2.redhat.com [10.3.113.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 694F17A1E1; Mon, 8 Jun 2020 15:53:28 +0000 (UTC) Subject: Re: [PATCH v4] numa: forbid '-numa node,mem' for 5.1 and newer machine types To: Igor Mammedov , qemu-devel@nongnu.org References: <20200608120344.728549-1-imammedo@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <06e37d7b-db66-e39c-22f1-5eff7370927b@redhat.com> Date: Mon, 8 Jun 2020 10:53:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200608120344.728549-1-imammedo@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ehabkost@redhat.com, mst@redhat.com, libvir-list@redhat.com, Michal Privoznik , groug@kaod.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/8/20 7:03 AM, Igor Mammedov wrote: > Deprecation period is run out and it's a time to flip the switch > introduced by cd5ff8333a. Disable legacy option for new machine > types (since 5.1) and amend documentation. > > '-numa node,memdev' shall be used instead of disabled option > with new machine types. > > Signed-off-by: Igor Mammedov > Reviewed-by: Michal Privoznik > --- > +++ b/docs/system/deprecated.rst > @@ -101,23 +101,6 @@ error in the future. > The ``-realtime mlock=on|off`` argument has been replaced by the > ``-overcommit mem-lock=on|off`` argument. > > -``-numa node,mem=``\ *size* (since 4.1) > -''''''''''''''''''''''''''''''''''''''' > - > -The parameter ``mem`` of ``-numa node`` is used to assign a part of Present tense in the old text made sense because the old way still worked... > -guest RAM to a NUMA node. But when using it, it's impossible to manage specified > -RAM chunk on the host side (like bind it to a host node, setting bind policy, ...), > -so guest end-ups with the fake NUMA configuration with suboptiomal performance. > -However since 2014 there is an alternative way to assign RAM to a NUMA node > -using parameter ``memdev``, which does the same as ``mem`` and adds > -means to actualy manage node RAM on the host side. Use parameter ``memdev`` > -with *memory-backend-ram* backend as an replacement for parameter ``mem`` > -to achieve the same fake NUMA effect or a properly configured > -*memory-backend-file* backend to actually benefit from NUMA configuration. > -In future new machine versions will not accept the option but it will still > -work with old machine types. User can check QAPI schema to see if the legacy > -option is supported by looking at MachineInfo::numa-mem-supported property. > - > ``-numa`` node (without memory specified) (since 4.1) > ''''''''''''''''''''''''''''''''''''''''''''''''''''' > > @@ -516,3 +499,23 @@ long starting at 1MiB, the old command:: > can be rewritten as:: > > qemu-nbd -t --image-opts driver=raw,offset=1M,size=100M,file.driver=qcow2,file.file.driver=file,file.file.filename=file.qcow2 > + > +Command line options > +-------------------- > + > +``-numa node,mem=``\ *size* (removed in 5.1) > +'''''''''''''''''''''''''''''''''''''''''''' > + > +The parameter ``mem`` of ``-numa node`` is used to assign a part of ...but in the new text, if we completely got rid of 'mem', then past tense is preferred to describe what used to work. s/is/was/ Other pre-existing typo and grammar problems worth fixing now: > +guest RAM to a NUMA node. But when using it, it's impossible to manage specified s/manage/manage a/ > +RAM chunk on the host side (like bind it to a host node, setting bind policy, ...), > +so guest end-ups with the fake NUMA configuration with suboptiomal performance. s/so guest end-ups/so the guest ends up/ > +However since 2014 there is an alternative way to assign RAM to a NUMA node > +using parameter ``memdev``, which does the same as ``mem`` and adds > +means to actualy manage node RAM on the host side. Use parameter ``memdev`` s/actualy/actually/ > +with *memory-backend-ram* backend as an replacement for parameter ``mem`` s/an/a/ > +to achieve the same fake NUMA effect or a properly configured > +*memory-backend-file* backend to actually benefit from NUMA configuration. > +In future new machine versions will not accept the option but it will still If this sentence is still true: s/In future new/New/ If the sentence is false (that is, we completely dropped 'mem' even for old machine versions), drop it. > +work with old machine types. User can check QAPI schema to see if the legacy s/check/check the/ > +option is supported by looking at MachineInfo::numa-mem-supported property. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org