From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1769CE7717B for ; Sat, 7 Dec 2024 09:21:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJr00-0004a9-Jl; Sat, 07 Dec 2024 04:21:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJqzx-0004Zk-GB for qemu-devel@nongnu.org; Sat, 07 Dec 2024 04:21:13 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJqzv-0005RZ-Ug for qemu-devel@nongnu.org; Sat, 07 Dec 2024 04:21:13 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4349fb56260so18415305e9.3 for ; Sat, 07 Dec 2024 01:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733563270; x=1734168070; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IC7m/KyPoRokYoUodJq+MoEsSQ+WiBEiUbDYQMEv3ns=; b=dy5IbicLxkl0HYmWiQxwtOpEQZDx0bvNTYycwBTKHeI32kjJwa5sbCRHbrmKf+Wic8 mYg4oHks7ujExb8hs0Xog9MpoDP+0Hp0DQwM/2noQ++GBsWA/qZjnBxxgq9/6BnrX7V4 1ezgPUftJ1n1TivgLkPFNiSeeM8M2D9dhN779YDrg9Jd9J+K1/pmqn7uQcnE7Rcm3LHx 0Fh+Rl0PBWoN87x5CtJGRaRzyLzBrwlQkIjWxNUQISdDYqTrXPFwV7vjFOEPwSY5uzCO xp8smlvnwY4eue911bs2b1ISHNsJis6cBru5GYGCVd68v9JyCcx8eZbDMdhYDnCofRbf WZKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733563270; x=1734168070; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IC7m/KyPoRokYoUodJq+MoEsSQ+WiBEiUbDYQMEv3ns=; b=okmRw7xom6ymKHPdHvhfsHbF2VtTvHu3sTQqJaHwHuuXYG5vp8vefeQm4kILrcJv1C 6prE0Q3i/XViBalfh3HIxREQAQTvxNkpoW8qM0ASnIDVKsIsOJykn9MfnOdIaIVBsB9D TzK+MX9448H8jULmGkGQAwyR76PbOkMGebmlhT7OSpc3cYsATvrv7UURoJu+KuwYMphI tgEy6jq9bknTXeRYA2T1SBa1cFCpxHmdhW+AH1vHYqSBGA4dk4oVZfR0xfflcJyz7qaV tArRNbgxqmANYW0zblUlBWIAKWePLcR5aZ6EHbMJbOoklJyOYm1zyuks9ezeIFBcSkn9 thsg== X-Forwarded-Encrypted: i=1; AJvYcCW5FQ8ts0l/bsEzdF+e6EAwmHTcG5l2tp8fq0aGfCorMqzvB/MTaM01L8y+z3rj20cUX6ccOrH2W3vO@nongnu.org X-Gm-Message-State: AOJu0YyulvwgS9OJX77InZP8ifHtCHd5+caBltWiIJjiAcBLl8vmZywf iAsrDFrpTWXpUxRN27k0dv93VNYurJlso2lDYgI+m4ITRwvoDykzEkCo7V14jVQ= X-Gm-Gg: ASbGncv4SPCQK+lGCUgqCCXMx+wWHDdpwrJ2lAhqOJ3GUd0X9/iktuuQdHGH6IQMtXQ UZyV/6+WaPrk/3drhzOFCpMi12PbCN0XDrUwEKkYKUegRm+l0bJIOojeZ78d3uGJgP37Mg9WOSx fdrLJl9TnX8tOSk6fJgI9qC63SXcee2PwTnD3Oeo0i3tf5rFaUHQmXnYl4UgDr1k04c5Td6r1Hm uLik4Em52JbviJTDFpH/bBhtYoCbb7HfKHRWXowsPIScO2+4Ok/xJVoDpi0lqvmh9P+o2sbZWWz eCljrP+9Cjuia+IMwo+OxV/3ZRBVZvhW X-Google-Smtp-Source: AGHT+IEzkO49rE7qjUB2YWYY8taJ0ME1Rwzp9yBdNq3rhhQWpGtSY3AN7rjrkgb0dQnMVMySs9XOjQ== X-Received: by 2002:a05:600c:1386:b0:42c:c401:6d8b with SMTP id 5b1f17b1804b1-434ddea7f1fmr49259665e9.7.1733563269929; Sat, 07 Dec 2024 01:21:09 -0800 (PST) Received: from [192.168.1.17] (lfbn-bay-1-170-196.w83-193.abo.wanadoo.fr. [83.193.250.196]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434da0d6a07sm79924405e9.13.2024.12.07.01.21.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Dec 2024 01:21:08 -0800 (PST) Message-ID: <06e90014-40b3-4928-b61f-6598193151f1@linaro.org> Date: Sat, 7 Dec 2024 10:21:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 06/13] rust: add bindings for memattrs To: Peter Maydell , Paolo Bonzini Cc: Richard Henderson , Zhao Liu , "Michael S . Tsirkin" , Manos Pitsidianakis , Junjie Mao , =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, qemu-rust@nongnu.org References: <20241205060714.256270-1-zhao1.liu@intel.com> <20241205060714.256270-7-zhao1.liu@intel.com> <1f008c2a-aaf6-497d-becd-f36f5d9aea17@redhat.com> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/12/24 11:59, Peter Maydell wrote: > On Thu, 5 Dec 2024 at 18:30, Paolo Bonzini wrote: >> >> On 12/5/24 19:15, Richard Henderson wrote: >>> On 12/5/24 00:07, Zhao Liu wrote: >>>> The MemTxAttrs structure is composed of bitfield members, and bindgen is >>>> unable to generate an equivalent macro definition for >>>> MEMTXATTRS_UNSPECIFIED. >>> >>> I'm happy to move away from bit fields to uint32_t or suchlike to enable >>> MEMTXATTRS_UNSPECIFIED be a compile-time constant. >> >> Yeah, if we go from >> >> typedef struct MemTxAttrs { >> unsigned int unspecified:1; >> unsigned int secure:1; >> unsigned int space:2; >> unsigned int user:1; >> unsigned int memory:1; >> unsigned int requester_id:16; >> unsigned int pid:8; >> } MemTxAttrs; >> >> to >> >> typedef struct MemTxAttrs { >> uint8_t unspecified; >> uint8_t secure; >> uint8_t space; >> uint8_t user; >> uint8_t memory; >> uint8_t pid; >> uint16_t requester_id; >> } MemTxAttrs; >> >> is still decently packed and simplifies things a lot. > > The old struct is 4 bytes, and the new one is 8 bytes. We do > a lot of directly passing 'struct MemTxAttrs' arguments around > as arguments to functions (i.e. not passing pointers to them), > so increasing it in size is not completely free. Should we add a check to not pass 8 bytes? QEMU_BUILD_BUG_ON(sizeof(MemTxAttrs) != sizeof(uint64_t));