From: Hannes Reinecke <hare@suse.de>
To: Klaus Jensen <its@irrelevant.dk>, qemu-devel@nongnu.org
Cc: Keith Busch <kbusch@kernel.org>,
Klaus Jensen <k.jensen@samsung.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH 1/4] hw/nvme: remove NvmeCtrl parameter from ns setup/check functions
Date: Wed, 7 Jul 2021 09:45:05 +0200 [thread overview]
Message-ID: <06eef17c-eae7-213e-9e14-3f40b7081d39@suse.de> (raw)
In-Reply-To: <20210706093358.1036387-2-its@irrelevant.dk>
On 7/6/21 11:33 AM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> The nvme_ns_setup and nvme_ns_check_constraints should not depend on the
> controller state. Refactor and remove it.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/nvme/nvme.h | 2 +-
> hw/nvme/ctrl.c | 2 +-
> hw/nvme/ns.c | 37 ++++++++++++++++++-------------------
> 3 files changed, 20 insertions(+), 21 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-07-07 7:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 9:33 [PATCH 0/4] hw/nvme: fix controller hotplugging Klaus Jensen
2021-07-06 9:33 ` [PATCH 1/4] hw/nvme: remove NvmeCtrl parameter from ns setup/check functions Klaus Jensen
2021-07-07 7:45 ` Hannes Reinecke [this message]
2021-07-06 9:33 ` [PATCH 2/4] hw/nvme: mark nvme-subsys non-hotpluggable Klaus Jensen
2021-07-07 7:45 ` Hannes Reinecke
2021-07-06 9:33 ` [PATCH 3/4] hw/nvme: unregister controller with subsystem at exit Klaus Jensen
2021-07-07 7:46 ` Hannes Reinecke
2021-07-06 9:33 ` [PATCH 4/4] hw/nvme: fix controller hot unplugging Klaus Jensen
2021-07-07 7:49 ` Hannes Reinecke
2021-07-07 9:53 ` Klaus Jensen
2021-07-07 10:43 ` Hannes Reinecke
2021-07-07 15:41 ` Klaus Jensen
2021-07-07 16:14 ` Stefan Hajnoczi
2021-07-07 16:47 ` Klaus Jensen
2021-07-08 6:15 ` Hannes Reinecke
2021-07-07 10:02 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06eef17c-eae7-213e-9e14-3f40b7081d39@suse.de \
--to=hare@suse.de \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).