From: Eric Blake <eblake@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH trivial] scripts/argparse.py: spelling (independant)
Date: Thu, 11 Jan 2018 08:46:14 -0600 [thread overview]
Message-ID: <06f69aed-3a7c-1f78-e83e-64e0fbd64791@redhat.com> (raw)
In-Reply-To: <20180111143201.17865-1-mjt@msgid.tls.msk.ru>
[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]
On 01/11/2018 08:32 AM, Michael Tokarev wrote:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> scripts/argparse.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/argparse.py b/scripts/argparse.py
> index 288c1f06c0..27d1f28935 100644
> --- a/scripts/argparse.py
> +++ b/scripts/argparse.py
From the top of the file:
# This is a local copy of the standard library argparse module taken
from PyPI.
# It is licensed under the Python Software Foundation License. This is a
# fallback for Python 2.6 which does not include this module. Python
2.7+ and
# 3+ will never load this module because built-in modules are loaded before
# anything in sys.path.
> @@ -76,7 +76,7 @@ considered public as object names -- the API of the formatter objects is
> still considered an implementation detail.)
> """
>
> -__version__ = '1.4.0' # we use our own version number independant of the
> +__version__ = '1.4.0' # we use our own version number independent of the
> # one in stdlib and we release this on pypi.
Is this typo still present in the upstream source that we copied from?
It's our local downstream copy, so we can tweak it, but we might want to
feed this one back upstream.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
prev parent reply other threads:[~2018-01-11 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 14:32 [Qemu-devel] [PATCH trivial] scripts/argparse.py: spelling (independant) Michael Tokarev
2018-01-11 14:46 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06f69aed-3a7c-1f78-e83e-64e0fbd64791@redhat.com \
--to=eblake@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).