Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDBus

[Thomas Huth <thuth@redhat.com>]

On 08/03/2019 17.11, Philippe Mathieu-Daudé wrote:
> Hi Markus,
> 
> [Asking again from the correct series thread]
> 
> On 1/3/18 10:49 PM, Philippe Mathieu-Daudé wrote:
>> Use Base64 to serialize the binary blobs in JSON.
>> So far at most 512 bytes will be transfered, which result
>> in a 684 bytes payload.
>> Since this command is intented for qtesting, it is acceptable.
> 
> Any comment regarding QMP for this patch?

Is this useful for anybody else than qtest? If not, I think this should
rather go into the qtest protocol instead, since QMP is our "public"
protocol.

>> diff --git a/hw/sd/sdbus-qmp.c b/hw/sd/sdbus-qmp.c
>> new file mode 100644
>> index 0000000000..8c4b6f2aee
>> --- /dev/null
>> +++ b/hw/sd/sdbus-qmp.c
>> @@ -0,0 +1,65 @@
>> +/*
>> + * SD card bus QMP debugging interface (for QTesting).
>> + *
>> + * Copyright (c) 2017 ?

Weird line. Add you name here ?

 Thomas