From: Thomas Huth <thuth@redhat.com>
To: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Jon Doron <arilou@gmail.com>,
Roman Kagan <rkagan@virtuozzo.com>
Subject: Re: [PATCH 0/2] Improve vmstate_vmbus_dev handling
Date: Mon, 7 Jun 2021 09:16:00 +0200 [thread overview]
Message-ID: <071039e6-2364-d9f3-2b19-ea2cbf454d2a@redhat.com> (raw)
In-Reply-To: <29f1529e-5865-db7e-698d-e7a046f012a3@oracle.com>
On 05/06/2021 18.01, Maciej S. Szmigiero wrote:
> Hi Thomas,
>
> On 03.06.2021 12:41, Thomas Huth wrote:
>> I accidentally came accross vmstate_vmbus_dev and noticed that
>> it is currently not used at all ... wire it up and make it
>> static, since it is only used in one file.
>>
>> Thomas Huth (2):
>> hw/hyperv/vmbus: Wire up vmstate_vmbus_dev
>> hw/hyperv/vmbus: Make vmstate_vmbus_dev static
>>
>> hw/hyperv/vmbus.c | 29 +++++++++++++++--------------
>> include/hw/hyperv/vmbus.h | 3 ---
>> 2 files changed, 15 insertions(+), 17 deletions(-)
>>
>
> I think the idea is to embed vmstate_vmbus_dev into a child device
> VMStateDescription using VMSTATE_STRUCT() - since particular VMBus
> devices aren't merged yet there are currently no users of it.
Ok, then never mind. But some comments in the source code would be really
helpful - in the current shape, it simply looks like an oversight...
Thomas
prev parent reply other threads:[~2021-06-07 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 10:41 [PATCH 0/2] Improve vmstate_vmbus_dev handling Thomas Huth
2021-06-03 10:41 ` [PATCH 1/2] hw/hyperv/vmbus: Wire up vmstate_vmbus_dev Thomas Huth
2021-06-03 10:41 ` [PATCH 2/2] hw/hyperv/vmbus: Make vmstate_vmbus_dev static Thomas Huth
2021-06-05 16:01 ` [PATCH 0/2] Improve vmstate_vmbus_dev handling Maciej S. Szmigiero
2021-06-07 7:16 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=071039e6-2364-d9f3-2b19-ea2cbf454d2a@redhat.com \
--to=thuth@redhat.com \
--cc=arilou@gmail.com \
--cc=maciej.szmigiero@oracle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).