From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/intc/armv7m_nvic: Remove stale comment
Date: Mon, 14 Jun 2021 11:56:45 -0700 [thread overview]
Message-ID: <0711ccff-ee4b-ee0e-0ab9-fc789c283136@linaro.org> (raw)
In-Reply-To: <20210614161243.14211-1-peter.maydell@linaro.org>
On 6/14/21 9:12 AM, Peter Maydell wrote:
> In commit da6d674e509f0939b we split the NVIC code out from the GIC.
> This allowed us to specify the NVIC's default value for the num-irq
> property (64) in the usual way in its property list, and we deleted
> the previous hack where we updated the value in the state struct in
> the instance init function. Remove a stale comment about that hack
> which we forgot to delete at that time.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> hw/intc/armv7m_nvic.c | 6 ------
> 1 file changed, 6 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2021-06-14 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 16:12 [PATCH] hw/intc/armv7m_nvic: Remove stale comment Peter Maydell
2021-06-14 16:17 ` Philippe Mathieu-Daudé
2021-06-14 18:56 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0711ccff-ee4b-ee0e-0ab9-fc789c283136@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).