From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Yonggang Luo" <luoyonggang@gmail.com>,
"Li-Wen Hsu" <lwhsu@freebsd.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>, "Ed Maste" <emaste@freebsd.org>,
"Bandan Das" <bsd@redhat.com>, "Cleber Rosa" <crosa@redhat.com>,
"Qiuhao Li" <Qiuhao.Li@outlook.com>,
qemu-block@nongnu.org, "Beraldo Leal" <bleal@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
qemu-arm@nongnu.org, "Michael Roth" <michael.roth@amd.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 04/14] tests: be a bit more strict cleaning up fifos
Date: Tue, 21 Feb 2023 11:36:54 +0100 [thread overview]
Message-ID: <07192b8a-c6e3-6dcb-ada3-35842f800068@linaro.org> (raw)
In-Reply-To: <20230221094558.2864616-5-alex.bennee@linaro.org>
On 21/2/23 10:45, Alex Bennée wrote:
> When we re-factored we dropped the unlink() step which turns out to be
> required for rmdir to do its thing. If we had been checking the return
> value we would have noticed so lets do that with this fix.
>
> Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> tests/unit/test-io-channel-command.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Per v1
https://lore.kernel.org/qemu-devel/20230215192530.299263-5-alex.bennee@linaro.org/
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-02-21 10:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 9:45 [PATCH v2 00/14] testing/next: docker, avocado, unit, gitlab Alex Bennée
2023-02-21 9:45 ` [PATCH v2 01/14] block: Handle curl 7.55.0, 7.85.0 version changes Alex Bennée
2023-02-21 10:57 ` Kevin Wolf
2023-02-21 11:08 ` Alex Bennée
2023-02-21 9:45 ` [PATCH v2 02/14] tests: don't run socat tests on MacOS as well Alex Bennée
2023-02-21 9:45 ` [PATCH v2 03/14] tests: add socat dependency for tests Alex Bennée
2023-02-21 9:45 ` [PATCH v2 04/14] tests: be a bit more strict cleaning up fifos Alex Bennée
2023-02-21 10:07 ` Thomas Huth
2023-02-21 10:36 ` Philippe Mathieu-Daudé [this message]
2023-02-21 9:45 ` [PATCH v2 05/14] tests: make fp-test less chatty when running from test suite Alex Bennée
2023-02-21 10:04 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 06/14] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs Alex Bennée
2023-02-21 9:45 ` [PATCH v2 07/14] gitlab: extend custom runners with base_job_template Alex Bennée
2023-02-21 10:52 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 08/14] tests: don't run benchmarks for the tsan build Alex Bennée
2023-02-21 10:54 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 09/14] testing: update ubuntu2004 to ubuntu2204 Alex Bennée
2023-02-21 10:56 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 10/14] tests: skip the nios2 replay_kernel test Alex Bennée
2023-02-21 9:45 ` [PATCH v2 11/14] tests: add tuxrun baseline test to avocado Alex Bennée
2023-02-21 10:17 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 12/14] tests/docker: Use binaries for debian-tricore-cross Alex Bennée
2023-02-21 9:45 ` [PATCH v2 13/14] tests: ensure we export job results for some cross builds Alex Bennée
2023-02-21 10:11 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 14/14] cirrus.yml: Improve the windows_msys2_task Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07192b8a-c6e3-6dcb-ada3-35842f800068@linaro.org \
--to=philmd@linaro.org \
--cc=Qiuhao.Li@outlook.com \
--cc=alex.bennee@linaro.org \
--cc=alxndr@bu.edu \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=bsd@redhat.com \
--cc=crosa@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=emaste@freebsd.org \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kwolf@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=lwhsu@freebsd.org \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).