From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, Jeff Cody <jcody@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com,
famz@redhat.com, kwolf@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for-2.11 1/4] blockjob: do not allow coroutine double entry or entry-after-completion
Date: Tue, 21 Nov 2017 14:12:32 +0100 [thread overview]
Message-ID: <072692b7-3b3e-b44d-02c8-9d8f4e745b67@redhat.com> (raw)
In-Reply-To: <20171121104946.GA25265@stefanha-x1.localdomain>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On 21/11/2017 11:49, Stefan Hajnoczi wrote:
> On Mon, Nov 20, 2017 at 09:23:23PM -0500, Jeff Cody wrote:
>> @@ -291,10 +291,10 @@ void block_job_start(BlockJob *job)
>> {
>> assert(job && !block_job_started(job) && job->paused &&
>> job->driver && job->driver->start);
>> - job->co = qemu_coroutine_create(block_job_co_entry, job);
>> job->pause_count--;
>> job->busy = true;
>> job->paused = false;
>> + job->co = qemu_coroutine_create(block_job_co_entry, job);
>> bdrv_coroutine_enter(blk_bs(job->blk), job->co);
>> }
>
> Please see discussion on v1 about this hunk.
>
> The rest looks good.
I'm okay with this hunk, but I would appreciate that the commit message
said why it's okay to delay block job cancellation after
block_job_sleep_ns returns.
Thanks,
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-11-21 13:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 2:23 [Qemu-devel] [PATCH v2 for-2.11 0/4] Fix segfault in blockjob race condition Jeff Cody
2017-11-21 2:23 ` [Qemu-devel] [PATCH v2 for-2.11 1/4] blockjob: do not allow coroutine double entry or entry-after-completion Jeff Cody
2017-11-21 10:49 ` Stefan Hajnoczi
2017-11-21 13:12 ` Paolo Bonzini [this message]
2017-11-21 13:26 ` Jeff Cody
2017-11-21 2:23 ` [Qemu-devel] [PATCH v2 for-2.11 2/4] coroutine: abort if we try to schedule or enter a pending coroutine Jeff Cody
2017-11-21 10:59 ` Stefan Hajnoczi
2017-11-21 13:11 ` Paolo Bonzini
2017-11-21 12:20 ` Eric Blake
2017-11-21 13:47 ` Kevin Wolf
2017-11-21 15:11 ` Paolo Bonzini
2017-11-21 2:23 ` [Qemu-devel] [PATCH v2 for-2.11 3/4] qemu-iotests: add option in common.qemu for mismatch only Jeff Cody
2017-11-21 2:23 ` [Qemu-devel] [PATCH v2 for-2.11 4/4] qemu-iotest: add test for blockjob coroutine race condition Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=072692b7-3b3e-b44d-02c8-9d8f4e745b67@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).