From: Max Reitz <mreitz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/5] iotests: skip 159 & 170 with luks format
Date: Sun, 12 Feb 2017 01:06:47 +0100 [thread overview]
Message-ID: <072d7d6f-d5ad-efe3-db77-364647593a81@redhat.com> (raw)
In-Reply-To: <20170124115748.21473-2-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On 24.01.2017 12:57, Daniel P. Berrange wrote:
> While the qemu-img dd command does accept --image-opts
> this is not sufficient to make it work with the LUKS
> image yet. This is because bdrv_create() still always
> requires the non-image-opts syntax.
>
> Thus we must skip 159/170 with luks for now
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> tests/qemu-iotests/159 | 2 +-
> tests/qemu-iotests/170 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
https://github.com/XanClic/qemu/commit/b4a2caa4bd5ad4e3cd6dd7eb1c0067d9205280cb
introduces _unsupported_fmt. Would that be a better fit?
(Yes, I'll send a pull request today.)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2017-02-12 0:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 11:57 [Qemu-devel] [PATCH v3 0/5] Improve I/O tests coverage of LUKS Daniel P. Berrange
2017-01-24 11:57 ` [Qemu-devel] [PATCH v3 1/5] iotests: skip 159 & 170 with luks format Daniel P. Berrange
2017-02-12 0:06 ` Max Reitz [this message]
2017-01-24 11:57 ` [Qemu-devel] [PATCH v3 2/5] iotests: fix remainining tests to work with LUKS Daniel P. Berrange
2017-02-12 0:50 ` Max Reitz
2017-01-24 11:57 ` [Qemu-devel] [PATCH v3 3/5] iotests: reduce PBKDF iterations when testing LUKS Daniel P. Berrange
2017-01-24 11:57 ` [Qemu-devel] [PATCH v3 4/5] iotests: add more LUKS hash combination tests Daniel P. Berrange
2017-01-24 11:57 ` [Qemu-devel] [PATCH v3 5/5] iotests: chown LUKS device before qemu-io launches Daniel P. Berrange
2017-02-09 14:42 ` [Qemu-devel] [PATCH v3 0/5] Improve I/O tests coverage of LUKS Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=072d7d6f-d5ad-efe3-db77-364647593a81@redhat.com \
--to=mreitz@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).