From: Max Reitz <mreitz@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] block: assert no image modification under BDRV_O_INACTIVE
Date: Thu, 13 Apr 2017 21:09:59 +0200 [thread overview]
Message-ID: <072e397c-520b-3a93-c447-d5ec1501dbf0@redhat.com> (raw)
In-Reply-To: <1491405505-31620-3-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On 05.04.2017 17:18, Denis V. Lunev wrote:
> As long as BDRV_O_INACTIVE is set, the image file is only opened so we
> have a file descriptor for it. We're definitely not supposed to modify
> the image, it's still owned by the migration source.
>
> This commit is an addition to 09e0c771 but the assert() is added to
> bdrv_truncate().
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Max Reitz <mreitz@redhat.com>
> ---
> block.c | 2 ++
> 1 file changed, 2 insertions(+)
Thanks to the new op blockers I'm not sure this is really necessary
anymore (that assertion should cover this, once it's reinstated, that
is...), but it won't hurt, I guess.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2017-04-13 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 15:18 [Qemu-devel] [PATCH for 2.10 0/2] block: simple changes Denis V. Lunev
2017-04-05 15:18 ` [Qemu-devel] [PATCH 1/2] block: fix obvious coding style mitakes in block_int.h Denis V. Lunev
2017-04-05 15:35 ` Eric Blake
2017-04-13 19:01 ` Max Reitz
2017-04-05 15:18 ` [Qemu-devel] [PATCH 2/2] block: assert no image modification under BDRV_O_INACTIVE Denis V. Lunev
2017-04-05 15:37 ` Eric Blake
2017-04-05 15:47 ` Denis V. Lunev
2017-04-13 19:09 ` Max Reitz [this message]
2017-04-13 19:11 ` [Qemu-devel] [PATCH for 2.10 0/2] block: simple changes Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=072e397c-520b-3a93-c447-d5ec1501dbf0@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).