From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9337FCD80B9 for ; Tue, 10 Oct 2023 11:53:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqBIL-0004ud-8L; Tue, 10 Oct 2023 07:53:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqBIJ-0004tq-9x; Tue, 10 Oct 2023 07:52:59 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqBIG-0007RF-Q0; Tue, 10 Oct 2023 07:52:59 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 33CD57456AA; Tue, 10 Oct 2023 13:51:57 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id F15B97456A7; Tue, 10 Oct 2023 13:51:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id EF0D2745681; Tue, 10 Oct 2023 13:51:56 +0200 (CEST) Date: Tue, 10 Oct 2023 13:51:56 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= cc: qemu-devel@nongnu.org, Eric Blake , qemu-arm@nongnu.org, Markus Armbruster , =?ISO-8859-15?Q?Daniel_P=2E_Berrang=E9?= , Thomas Huth , Peter Maydell , qemu-ppc@nongnu.org, =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= , "Dr. David Alan Gilbert" , Gerd Hoffmann , "Michael S. Tsirkin" , Paolo Bonzini Subject: Re: [PATCH v3 17/18] hw/display: make ATI_VGA depend on PIXMAN In-Reply-To: <20231010073830.606570-18-marcandre.lureau@redhat.com> Message-ID: <074ec11f-30a0-a70e-fd24-d264925a1df9@eik.bme.hu> References: <20231010073830.606570-1-marcandre.lureau@redhat.com> <20231010073830.606570-18-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-372921519-1696938716=:36553" Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-372921519-1696938716=:36553 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 10 Oct 2023, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Acked-by: BALATON Zoltan > --- > configs/devices/mips64el-softmmu/default.mak | 2 +- > hw/display/Kconfig | 2 +- > hw/display/meson.build | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configs/devices/mips64el-softmmu/default.mak b/configs/devices/mips64el-softmmu/default.mak > index d5188f7ea5..8d85607571 100644 > --- a/configs/devices/mips64el-softmmu/default.mak > +++ b/configs/devices/mips64el-softmmu/default.mak > @@ -3,7 +3,7 @@ > include ../mips-softmmu/common.mak > CONFIG_FULOONG=y > CONFIG_LOONGSON3V=y > -CONFIG_ATI_VGA=y > +# CONFIG_ATI_VGA=n > CONFIG_RTL8139_PCI=y > CONFIG_JAZZ=y > CONFIG_VT82C686=y > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 1aafe1923d..4d8a6c4af8 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -125,7 +125,7 @@ config DPCD > config ATI_VGA > bool > default y if PCI_DEVICES > - depends on PCI > + depends on PCI && PIXMAN > select VGA > select BITBANG_I2C > select DDC > diff --git a/hw/display/meson.build b/hw/display/meson.build > index 14a57703d3..4a10040c19 100644 > --- a/hw/display/meson.build > +++ b/hw/display/meson.build > @@ -62,7 +62,7 @@ system_ss.add(when: 'CONFIG_XLNX_DISPLAYPORT', if_true: files('xlnx_dp.c')) > > system_ss.add(when: 'CONFIG_ARTIST', if_true: files('artist.c')) > > -system_ss.add(when: [pixman, 'CONFIG_ATI_VGA'], if_true: files('ati.c', 'ati_2d.c', 'ati_dbg.c')) > +system_ss.add(when: 'CONFIG_ATI_VGA', if_true: [files('ati.c', 'ati_2d.c', 'ati_dbg.c'), pixman]) > > > if config_all_devices.has_key('CONFIG_VIRTIO_GPU') > --3866299591-372921519-1696938716=:36553--