From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
qemu-s390x@nongnu.org
Subject: Re: [PATCH v3 5/7] hw/arm: Remove all invalid uses of auto_create_sdcard=true
Date: Tue, 4 Feb 2025 20:12:26 +0100 [thread overview]
Message-ID: <075834df-6e81-43f8-81e0-2b2df5b9a828@linaro.org> (raw)
In-Reply-To: <20250204182903.59200-6-philmd@linaro.org>
On 4/2/25 19:29, Philippe Mathieu-Daudé wrote:
> MachineClass::auto_create_sdcard is only useful to automatically
> create a SD card, attach a IF_SD block drive to it and plug the
> card onto a SD bus. None of the ARM machines modified by this
> commit try to use the IF_SD interface.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/arm/aspeed.c | 21 ---------------------
> hw/arm/b-l475e-iot01a.c | 1 -
> hw/arm/bananapi_m2u.c | 1 -
> hw/arm/collie.c | 1 -
> hw/arm/digic_boards.c | 1 -
> hw/arm/exynos4_boards.c | 2 --
> hw/arm/fby35.c | 1 -
> hw/arm/highbank.c | 2 --
> hw/arm/imx25_pdk.c | 1 -
> hw/arm/kzm.c | 1 -
> hw/arm/mcimx6ul-evk.c | 1 -
> hw/arm/mcimx7d-sabre.c | 3 ++-
> hw/arm/microbit.c | 1 -
> hw/arm/mps2-tz.c | 4 ----
> hw/arm/mps2.c | 4 ----
> hw/arm/mps3r.c | 1 -
> hw/arm/msf2-som.c | 1 -
> hw/arm/musca.c | 2 --
> hw/arm/musicpal.c | 1 -
> hw/arm/netduino2.c | 1 -
> hw/arm/netduinoplus2.c | 1 -
> hw/arm/olimex-stm32-h405.c | 1 -
> hw/arm/raspi.c | 5 -----
> hw/arm/raspi4b.c | 1 -
> hw/arm/sabrelite.c | 1 -
> hw/arm/sbsa-ref.c | 1 -
> hw/arm/stellaris.c | 1 -
> hw/arm/stm32vldiscovery.c | 1 -
> hw/arm/versatilepb.c | 2 --
> hw/arm/virt.c | 1 -
> hw/arm/xen-pvh.c | 1 -
> hw/arm/xlnx-versal-virt.c | 1 -
> hw/arm/xlnx-zcu102.c | 1 -
> 33 files changed, 2 insertions(+), 67 deletions(-)
As Thomas noted in v2, this patch isn't correct.
next prev parent reply other threads:[~2025-02-04 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 18:28 [PATCH v3 0/7] hw/boards: Try to make sense of MachineClass::no_sdcard flag Philippe Mathieu-Daudé
2025-02-04 18:28 ` [PATCH v3 1/7] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state Philippe Mathieu-Daudé
2025-02-04 18:28 ` [PATCH v3 2/7] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF Philippe Mathieu-Daudé
2025-02-04 18:28 ` [PATCH v3 3/7] hw/boards: Rename no_sdcard -> auto_create_sdcard Philippe Mathieu-Daudé
2025-02-04 18:29 ` [PATCH v3 4/7] hw/boards: Remove all invalid uses of auto_create_sdcard=true Philippe Mathieu-Daudé
2025-02-04 18:29 ` [PATCH v3 5/7] hw/arm: " Philippe Mathieu-Daudé
2025-02-04 19:12 ` Philippe Mathieu-Daudé [this message]
2025-02-04 18:29 ` [PATCH v3 6/7] hw/riscv: " Philippe Mathieu-Daudé
2025-02-04 18:29 ` [PATCH v3 7/7] hw/boards: Ensure machine setting auto_create_sdcard expose a SD Bus Philippe Mathieu-Daudé
2025-02-04 18:48 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=075834df-6e81-43f8-81e0-2b2df5b9a828@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).