qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tests/qtest: do not list ahci-test twice
@ 2020-09-04 12:03 Paolo Bonzini
  2020-09-04 12:11 ` Thomas Huth
  2020-09-04 12:46 ` Philippe Mathieu-Daudé
  0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-09-04 12:03 UTC (permalink / raw)
  To: qemu-devel; +Cc: lvivier, qemu-trivial, thuth

This is caught by "meson test", which complains about two tests with the
same name.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/qtest/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 8f8fdb1336..874b5be62b 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -49,7 +49,6 @@ qtests_i386 = \
   qtests_pci +                                                                              \
   ['fdc-test',
    'ide-test',
-   'ahci-test',
    'hd-geo-test',
    'boot-order-test',
    'bios-tables-test',
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests/qtest: do not list ahci-test twice
  2020-09-04 12:03 [PATCH] tests/qtest: do not list ahci-test twice Paolo Bonzini
@ 2020-09-04 12:11 ` Thomas Huth
  2020-09-04 12:46 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2020-09-04 12:11 UTC (permalink / raw)
  To: Paolo Bonzini, qemu-devel; +Cc: lvivier, qemu-trivial

On 04/09/2020 14.03, Paolo Bonzini wrote:
> This is caught by "meson test", which complains about two tests with the
> same name.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/qtest/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 8f8fdb1336..874b5be62b 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -49,7 +49,6 @@ qtests_i386 = \
>    qtests_pci +                                                                              \
>    ['fdc-test',
>     'ide-test',
> -   'ahci-test',
>     'hd-geo-test',
>     'boot-order-test',
>     'bios-tables-test',
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

... and since you just sent your meson PR without this, I can also take
it through my qtest-next tree.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests/qtest: do not list ahci-test twice
  2020-09-04 12:03 [PATCH] tests/qtest: do not list ahci-test twice Paolo Bonzini
  2020-09-04 12:11 ` Thomas Huth
@ 2020-09-04 12:46 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-04 12:46 UTC (permalink / raw)
  To: Paolo Bonzini, qemu-devel; +Cc: lvivier, qemu-trivial, thuth

On 9/4/20 2:03 PM, Paolo Bonzini wrote:
> This is caught by "meson test", which complains about two tests with the
> same name.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/qtest/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 8f8fdb1336..874b5be62b 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -49,7 +49,6 @@ qtests_i386 = \
>    qtests_pci +                                                                              \
>    ['fdc-test',
>     'ide-test',
> -   'ahci-test',
>     'hd-geo-test',
>     'boot-order-test',
>     'bios-tables-test',
> 

Fixes: a2ce7dbd917 ("meson: convert tests/qtest to meson")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-04 12:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-04 12:03 [PATCH] tests/qtest: do not list ahci-test twice Paolo Bonzini
2020-09-04 12:11 ` Thomas Huth
2020-09-04 12:46 ` Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).