* [Qemu-devel] [PATCH] sparc: Fix typedef clash
@ 2017-09-14 12:36 Dr. David Alan Gilbert (git)
2017-09-14 13:39 ` Philippe Mathieu-Daudé
2017-09-14 14:47 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2017-09-14 12:36 UTC (permalink / raw)
To: qemu-devel, mark.cave-ayland, atar4qemu, imammedo
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Older compilers (rhel6) don't like redefinition of typedefs
Fixes: 12a6c15ef31c98ecefa63e91ac36955383038384
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
target/sparc/cpu.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h
index b45cfb4708..1598f65927 100644
--- a/target/sparc/cpu.h
+++ b/target/sparc/cpu.h
@@ -240,7 +240,7 @@ typedef struct trap_state {
#endif
#define TARGET_INSN_START_EXTRA_WORDS 1
-typedef struct sparc_def_t {
+struct sparc_def_t {
const char *name;
target_ulong iu_version;
uint32_t fpu_version;
@@ -254,7 +254,7 @@ typedef struct sparc_def_t {
uint32_t features;
uint32_t nwindows;
uint32_t maxtl;
-} sparc_def_t;
+};
#define CPU_FEATURE_FLOAT (1 << 0)
#define CPU_FEATURE_FLOAT128 (1 << 1)
--
2.13.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] sparc: Fix typedef clash
2017-09-14 12:36 [Qemu-devel] [PATCH] sparc: Fix typedef clash Dr. David Alan Gilbert (git)
@ 2017-09-14 13:39 ` Philippe Mathieu-Daudé
2017-09-14 14:47 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-09-14 13:39 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), mark.cave-ayland, atar4qemu,
imammedo
Cc: qemu-devel
On 09/14/2017 09:36 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Older compilers (rhel6) don't like redefinition of typedefs
Newer neither (clang-5)
fatal error: redefinition of typedef [-Wtypedef-redefinition]
d61d1b20610
>
> Fixes: 12a6c15ef31c98ecefa63e91ac36955383038384
you mean "missed in 12a6c15ef31c98ecefa63e91ac36955383038384"
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/sparc/cpu.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h
> index b45cfb4708..1598f65927 100644
> --- a/target/sparc/cpu.h
> +++ b/target/sparc/cpu.h
> @@ -240,7 +240,7 @@ typedef struct trap_state {
> #endif
> #define TARGET_INSN_START_EXTRA_WORDS 1
>
> -typedef struct sparc_def_t {
> +struct sparc_def_t {
> const char *name;
> target_ulong iu_version;
> uint32_t fpu_version;
> @@ -254,7 +254,7 @@ typedef struct sparc_def_t {
> uint32_t features;
> uint32_t nwindows;
> uint32_t maxtl;
> -} sparc_def_t;
> +};
>
> #define CPU_FEATURE_FLOAT (1 << 0)
> #define CPU_FEATURE_FLOAT128 (1 << 1)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] sparc: Fix typedef clash
2017-09-14 12:36 [Qemu-devel] [PATCH] sparc: Fix typedef clash Dr. David Alan Gilbert (git)
2017-09-14 13:39 ` Philippe Mathieu-Daudé
@ 2017-09-14 14:47 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2017-09-14 14:47 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git)
Cc: QEMU Developers, Mark Cave-Ayland, Artyom Tarasenko,
Igor Mammedov
On 14 September 2017 at 13:36, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Older compilers (rhel6) don't like redefinition of typedefs
>
> Fixes: 12a6c15ef31c98ecefa63e91ac36955383038384
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Thanks; applied to master as a buildfix.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-14 14:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-14 12:36 [Qemu-devel] [PATCH] sparc: Fix typedef clash Dr. David Alan Gilbert (git)
2017-09-14 13:39 ` Philippe Mathieu-Daudé
2017-09-14 14:47 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).