From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Yuri Gribov <tetra2005@gmail.com>, qemu-devel@nongnu.org
Cc: Marek Vasut <marex@denx.de>,
Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Chris Wulff <crwulff@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PING^2] [PATCH] [NFC] Mark locally used symbols as static.
Date: Fri, 16 Apr 2021 07:03:49 +0200 [thread overview]
Message-ID: <075db5e1-ee1e-94eb-6903-68e3817b6e3e@redhat.com> (raw)
In-Reply-To: <CAJOtW+7NN2rkcnKmNmMqEUXAgFku+zECRZgv2LX1G73HM-d2NQ@mail.gmail.com>
Hi Yuri,
On 4/15/21 7:27 PM, Yuri Gribov wrote:
> Hi all,
>
> This patch makes locally used symbols static to enable more compiler
> optimizations on them. Some of the symbols turned out to not be used
> at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if
> they were ok to delete).
It would be easier to integrate your work if your split it
in multiple patches, and send them as a series, and add the
Reviewed-by/Acked-by tags to the corresponding ones (these
could be queued via the qemu-trival tree already). See below.
> The symbols have been identified with a pet project of mine:
> https://github.com/yugr/Localizer
>
> Link to patch: https://patchew.org/QEMU/CAJOtW+5DDMsr8QJQxaa1OHT79rpMJCrwkYbuaRTynR_ngUxgHA@mail.gmail.com/
>
> From 4e790fd06becfbbf6fb106ac52ae1e4515f1ac73 Mon Sep 17 00:00:00 2001
> From: Yury Gribov <tetra2005@gmail.com>
> Date: Sat, 20 Mar 2021 23:39:15 +0300
> Subject: [PATCH] Mark locally used symbols as static.
>
> Signed-off-by: Yury Gribov <tetra2005@gmail.com>
> Acked-by: Max Filippov <jcmvbkbc@gmail.com> (xtensa)
> Acked-by: David Gibson <david@gibson.dropbear.id.au> (ppc)
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> (tracetool)
> Reviewed-by: Taylor Simpson <tsimpson@quicinc.com> (hexagon)
> ---
> disas/alpha.c | 16 ++--
> disas/m68k.c | 78 ++++++++---------
> disas/mips.c | 14 ++--
> disas/nios2.c | 84 +++++++++----------
> disas/ppc.c | 26 +++---
> disas/riscv.c | 2 +-
patch #1, "disas: Mark locally used symbols as static"
> pc-bios/optionrom/linuxboot_dma.c | 4 +-
patch #2, "pc-bios/optionrom: Mark locally used symbols as static"
> scripts/tracetool/format/c.py | 2 +-
patch #3, "scripts/tracetool: Mark locally used symbols as static"
> target/hexagon/gen_dectree_import.c | 2 +-
> target/hexagon/opcodes.c | 2 +-
patch #4, "target/hexagon: Mark locally used symbols as static"
> target/i386/cpu.c | 2 +-
patch #5, "target/i386: Mark locally used symbols as static"
> target/s390x/cpu_models.c | 2 +-
patch #6, "target/s390x: Mark locally used symbols as static"
> .../xtensa/core-dc232b/xtensa-modules.c.inc | 2 +-
> .../xtensa/core-dc233c/xtensa-modules.c.inc | 2 +-
> target/xtensa/core-de212/xtensa-modules.c.inc | 2 +-
> .../core-de233_fpu/xtensa-modules.c.inc | 2 +-
> .../xtensa/core-dsp3400/xtensa-modules.c.inc | 2 +-
> target/xtensa/core-fsf/xtensa-modules.c.inc | 2 +-
> .../xtensa-modules.c.inc | 2 +-
> .../core-test_kc705_be/xtensa-modules.c.inc | 2 +-
> .../core-test_mmuhifi_c3/xtensa-modules.c.inc | 2 +-
patch #7, "target/xtensa: Mark locally used symbols as static"
> 21 files changed, 125 insertions(+), 127 deletions(-)
Regards,
Phil.
next prev parent reply other threads:[~2021-04-16 5:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 19:55 [PATCH] [NFC] Mark locally used symbols as static Yuri Gribov
2021-03-22 21:27 ` Max Filippov
2021-03-22 23:32 ` David Gibson
2021-03-23 13:36 ` Stefan Hajnoczi
2021-03-23 13:36 ` Stefan Hajnoczi
2021-03-23 14:57 ` Taylor Simpson
2021-03-30 6:49 ` [PING] " Yuri Gribov
2021-04-15 17:27 ` [PING^2] " Yuri Gribov
2021-04-16 5:03 ` Philippe Mathieu-Daudé [this message]
2021-04-16 5:08 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=075db5e1-ee1e-94eb-6903-68e3817b6e3e@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=crwulff@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
--cc=tetra2005@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).