From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47E7FCF3195 for ; Wed, 2 Oct 2024 06:49:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svtAi-0005i2-RR; Wed, 02 Oct 2024 02:49:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svtAg-0005hH-OW; Wed, 02 Oct 2024 02:49:14 -0400 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svtAe-0002fK-Qn; Wed, 02 Oct 2024 02:49:14 -0400 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4XJQQC5kd8z4wcj; Wed, 2 Oct 2024 16:49:07 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4XJQQ95ft2z4w2M; Wed, 2 Oct 2024 16:49:05 +1000 (AEST) Message-ID: <0780930a-626d-47cc-b2fb-1271d616e66b@kaod.org> Date: Wed, 2 Oct 2024 08:49:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/11] ppc/spapr: remove deprecated machine pseries-2.6 To: Harsh Prateek Bora , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Cc: npiggin@gmail.com, danielhb413@gmail.com References: <20241001092910.1030913-1-harshpb@linux.ibm.com> <20241001092910.1030913-7-harshpb@linux.ibm.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <20241001092910.1030913-7-harshpb@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=nzkv=Q6=kaod.org=clg@ozlabs.org; helo=mail.ozlabs.org X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/1/24 11:29, Harsh Prateek Bora wrote: > Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as > deprecated with reasons mentioned in its commit log. > Removing pseries-2.6 specific code with this patch for now. > > Suggested-by: Cédric Le Goater > Signed-off-by: Harsh Prateek Bora Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/ppc/spapr.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index a38d4e098a..d317387b7f 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -5297,24 +5297,6 @@ static void spapr_machine_2_7_class_options(MachineClass *mc) > > DEFINE_SPAPR_MACHINE(2, 7); > > -/* > - * pseries-2.6 > - */ > - > -static void spapr_machine_2_6_class_options(MachineClass *mc) > -{ > - static GlobalProperty compat[] = { > - { TYPE_SPAPR_PCI_HOST_BRIDGE, "ddw", "off" }, > - }; > - spapr_machine_2_7_class_options(mc);> - mc->has_hotpluggable_cpus = false; > - compat_props_add(mc->compat_props, hw_compat_2_6, hw_compat_2_6_len); > - compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); > -} > - > -DEFINE_SPAPR_MACHINE(2, 6); > - > static void spapr_machine_register_types(void) > { > type_register_static(&spapr_machine_info);