Re: [SPAM] [PATCH v1 08/21] hw/arm/ast27x0: Add SCU alias for SSP and ensure correct device realization order

["Cédric Le Goater" <clg@redhat.com>]

Hello Jamin,


>>> 3. Migrate all ASPEED coprocessors (e.g. SSP/TSP) to a common
>> AspeedCoprocessorState.
>>
>> Is 'AspeedCoprocessorState' a new model structure minimizing the number of
>> sub controllers ? if so, looks good. Could be merged fairly quickly.
>>
> 
> Yes, I am planning to use the new AspeedCoprocessorState instead of AspeedSoCState for SSP and TSP.
> struct Aspeed27x0SSPSoCState {
>      AspeedSoCState parent;  -------> Change to AspeedCoprocessorState
>      AspeedINTCState intc[2];
>      UnimplementedDeviceState ipc[2];
>      UnimplementedDeviceState scuio;
> 
>      ARMv7MState armv7m;
> };
> 
> struct Aspeed27x0TSPSoCState {
>      AspeedSoCState parent;  -------> Change to AspeedCoprocessorState
>      AspeedINTCState intc[2];
>      UnimplementedDeviceState ipc[2];
>      UnimplementedDeviceState scuio;
> 
>      ARMv7MState armv7m;
> };
> This change consolidates SSP and TSP under a common coprocessor model,
> reducing duplication and aligning them with the new AspeedCoprocessorState abstraction.

Aspeed27x0TSPSoCState and Aspeed27x0SSPSoCState look similar. Could they
be merged ?

Thanks,

C.