From: Thomas Huth <thuth@redhat.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, qemu-trivial@nongnu.org,
Anthony Perard <anthony.perard@citrix.com>,
qemu-devel@nongnu.org,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] include/hw/xen: Use more inclusive language in comment
Date: Fri, 10 Nov 2023 10:34:44 +0100 [thread overview]
Message-ID: <0795d03d-602d-4064-a3da-c019e4d12189@redhat.com> (raw)
In-Reply-To: <2ae66eda-3560-2930-4bbb-87345a719f32@suse.com>
On 10/11/2023 10.30, Jan Beulich wrote:
> On 09.11.2023 18:40, Thomas Huth wrote:
>> --- a/include/hw/xen/interface/hvm/params.h
>> +++ b/include/hw/xen/interface/hvm/params.h
>> @@ -255,7 +255,7 @@
>> * Note that 'mixed' mode has not been evaluated for safety from a
>> * security perspective. Before using this mode in a
>> * security-critical environment, each subop should be evaluated for
>> - * safety, with unsafe subops blacklisted in XSM.
>> + * safety, with unsafe subops blocked in XSM.
>
> To avoid another round trip when you send the patch against xen.git, as
> already asked for by others, I'd like to point out that the wording
> change isn't describing things sufficiently similarly: "blocked" reads
> as if XSM would do so all by itself, whereas "blacklisted" has an
> indication that something needs to be done for XSM to behave in the
> intended way. Minimally I'd suggest "suitably blocked via", but perhaps
> yet better wording can be thought of.
Ok, could then please someone from you Xen guys get this fixed with
appropriate wording in the xen.git repo? I never checked out that repo
before and before I now spend hours and hours to figure out how to
contribute a patch to Xen, just to replace a single word, it's way easier if
someone with pre-existing Xen experience is taking care of this.
Thanks,
Thomas
next prev parent reply other threads:[~2023-11-10 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 17:40 [PATCH] include/hw/xen: Use more inclusive language in comment Thomas Huth
2023-11-09 17:47 ` Daniel P. Berrangé
2023-11-09 19:10 ` Philippe Mathieu-Daudé
2023-11-09 23:27 ` Andrew Cooper
2023-11-10 9:12 ` David Woodhouse
2023-11-10 9:30 ` Jan Beulich
2023-11-10 9:34 ` Thomas Huth [this message]
2023-11-10 10:26 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0795d03d-602d-4064-a3da-c019e4d12189@redhat.com \
--to=thuth@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).