From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biSmM-00059E-5N for qemu-devel@nongnu.org; Fri, 09 Sep 2016 16:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biSmH-0000Op-6r for qemu-devel@nongnu.org; Fri, 09 Sep 2016 16:52:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biSmG-0000Oi-V8 for qemu-devel@nongnu.org; Fri, 09 Sep 2016 16:52:01 -0400 References: <1473453424-601-1-git-send-email-ashijeetacharya@gmail.com> From: Eric Blake Message-ID: <079874c0-5b2e-3eed-4bb7-827556bd59c0@redhat.com> Date: Fri, 9 Sep 2016 15:51:59 -0500 MIME-Version: 1.0 In-Reply-To: <1473453424-601-1-git-send-email-ashijeetacharya@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SqMqQtP68ieIOQfw8n4AMIuU1rPdWgX9G" Subject: Re: [Qemu-devel] [PATCH v3] migrate: Fix bounds check for migration parameters in migration.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya , quintela@redhat.com Cc: amit.shah@redhat.com, dgilbert@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SqMqQtP68ieIOQfw8n4AMIuU1rPdWgX9G From: Eric Blake To: Ashijeet Acharya , quintela@redhat.com Cc: amit.shah@redhat.com, dgilbert@redhat.com, qemu-devel@nongnu.org Message-ID: <079874c0-5b2e-3eed-4bb7-827556bd59c0@redhat.com> Subject: Re: [PATCH v3] migrate: Fix bounds check for migration parameters in migration.c References: <1473453424-601-1-git-send-email-ashijeetacharya@gmail.com> In-Reply-To: <1473453424-601-1-git-send-email-ashijeetacharya@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/09/2016 03:37 PM, Ashijeet Acharya wrote: > This patch fixes the out-of-bounds check of migration parameters in > qmp_migrate_set_parameters() for cpu-throttle-initial and > cpu-throttle-increment by adding a return statement for both as they > were broken since their introduction in 2.5 via commit 1626fee. > Due to the missing return statements, parameters were getting set to > out-of-bounds values despite the error. >=20 > Signed-off-by: Ashijeet Acharya > --- Remember, after the --- is a good place to give a description of how v3 is better than v1. Also, since I gave a reviewed-by on v1, and it looks like all you changed was the commit message, you can manually add my R-b line during your 'git commit --amend', so that reviewers can shave some time on the second round of reviews. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SqMqQtP68ieIOQfw8n4AMIuU1rPdWgX9G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX0yDvAAoJEKeha0olJ0NqBFoH/1C2KKgvtpPHfh4RKIFs60nL jQ4KAP5FTd+Mnd2AKG3XqVC2RzM91hV5z3lrRHA9dQYQYv9OX5Kw/5j2SLAv2SeJ iKcQg7VxjeOxvWxnf/ErbKg7YCWxUtLkHQoWp3821H8wdrG1y8gIhFuMj51foUiB 9McILis7G3i+mIOdgRjdKMuostkAmZlq8C07nP+ZtIaYDQH18yqDGrFHsMar7nUK aaN4oH+axfLafIfmw5CUXjJM1tVZk8GrrRWjRqz3AyMZT+2sxySwZ75Ls5u4AmNP G1w3uhhAAL0+37HwmOtHuharzEIqMDnkhUhDchlgBRBCfr+cBiRXKXV6Ci9rpBA= =IdW8 -----END PGP SIGNATURE----- --SqMqQtP68ieIOQfw8n4AMIuU1rPdWgX9G--