From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezHUm-0001IP-5o for qemu-devel@nongnu.org; Fri, 23 Mar 2018 03:52:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezHUh-00057t-A6 for qemu-devel@nongnu.org; Fri, 23 Mar 2018 03:52:16 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ezHUh-00055x-1M for qemu-devel@nongnu.org; Fri, 23 Mar 2018 03:52:11 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2N7lmmL002223 for ; Fri, 23 Mar 2018 03:52:08 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gvv96jw6q-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Fri, 23 Mar 2018 03:52:08 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Mar 2018 07:52:05 -0000 References: <20180320130702.188689-1-borntraeger@de.ibm.com> From: Christian Borntraeger Date: Fri, 23 Mar 2018 08:52:00 +0100 MIME-Version: 1.0 In-Reply-To: <20180320130702.188689-1-borntraeger@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <07af0b3c-a23d-b8b2-062c-756ab599650f@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/1] s390x/cpumodel: fix feature groups and breakage of MSA8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-s390x Cc: qemu-devel , Cornelia Huck , Thomas Huth , David Hildenbrand , Halil Pasic , Janosch Frank On 03/20/2018 02:07 PM, Christian Borntraeger wrote: > Since commit 46a99c9f73c7 ("s390x/cpumodel: model PTFF subfunctions > for Multiple-epoch facility") -cpu help no longer shows the MSA8 > feature group. Turns out that we forgot to add the new MEPOCH_PTFF > group enum. > > Fixes: 46a99c9f73c7 ("s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility") > Signed-off-by: Christian Borntraeger > --- > target/s390x/cpu_features.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/s390x/cpu_features.h b/target/s390x/cpu_features.h > index e306aa7ab2..968b12fdfe 100644 > --- a/target/s390x/cpu_features.h > +++ b/target/s390x/cpu_features.h > @@ -78,6 +78,7 @@ typedef enum { > S390_FEAT_GROUP_MSA_EXT_6, > S390_FEAT_GROUP_MSA_EXT_7, > S390_FEAT_GROUP_MSA_EXT_8, > + S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF, > S390_FEAT_GROUP_MAX, > } S390FeatGroup; > applied to my s390-next branch.