From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
qemu-arm@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH v2 4/4] hw/sensor/tmp105: Convert printf() to trace event, add tracing for read/write access
Date: Sun, 3 Nov 2024 21:25:12 +0100 [thread overview]
Message-ID: <07c00f31-508d-4a43-a0ca-0ee31ae7409a@linaro.org> (raw)
In-Reply-To: <20241103143330.123596-5-shentey@gmail.com>
On 3/11/24 11:33, Bernhard Beschow wrote:
> printf() unconditionally prints to the console which disturbs `-serial stdio`.
> Fix that by converting into a trace event. While at it, add some tracing for
> read and write access.
>
> Fixes: 7e7c5e4c1ba5 "Nokia N800 machine support (ARM)."
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> meson.build | 1 +
> hw/sensor/trace.h | 1 +
> hw/sensor/tmp105.c | 7 ++++++-
> hw/sensor/trace-events | 6 ++++++
> 4 files changed, 14 insertions(+), 1 deletion(-)
> create mode 100644 hw/sensor/trace.h
> create mode 100644 hw/sensor/trace-events
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-11-03 20:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 14:33 [PATCH v2 0/4] Trivial ARM changes Bernhard Beschow
2024-11-03 14:33 ` [PATCH v2 1/4] hw/rtc/ds1338: Trace send and receive operations Bernhard Beschow
2024-11-03 14:33 ` [PATCH v2 2/4] hw/timer/imx_gpt: Convert DPRINTF to trace events Bernhard Beschow
2024-11-03 14:33 ` [PATCH v2 3/4] hw/watchdog/wdt_imx2: Remove redundant assignment Bernhard Beschow
2024-11-04 11:20 ` Richard Henderson
2024-11-03 14:33 ` [PATCH v2 4/4] hw/sensor/tmp105: Convert printf() to trace event, add tracing for read/write access Bernhard Beschow
2024-11-03 20:25 ` Philippe Mathieu-Daudé [this message]
2024-11-04 13:50 ` [PATCH v2 0/4] Trivial ARM changes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c00f31-508d-4a43-a0ca-0ee31ae7409a@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=jcd@tribudubois.net \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).