From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, berrange@redhat.com, zxq_yx_007@163.com,
kraxel@redhat.com, marcandre.lureau@redhat.com
Subject: Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp
Date: Thu, 29 Oct 2020 19:06:19 +0100 [thread overview]
Message-ID: <07eb80c1-6d56-2bd4-c8be-90a34167ae91@redhat.com> (raw)
In-Reply-To: <20201029133833.3450220-1-armbru@redhat.com>
On 29/10/20 14:38, Markus Armbruster wrote:
> In my opinion, the Linux-specific abstract UNIX domain socket feature
> introduced in 5.1 should have been rejected. The feature is niche,
> the interface clumsy, the implementation buggy and incomplete, and the
> test coverage insufficient. Review fail.
>
> Fixing the parts we can still fix now is regrettably expensive. If I
> had the power to decide, I'd unceremoniously revert the feature,
> compatibility to 5.1 be damned. But I don't, so here we go.
>
> I'm not sure this set of fixes is complete. However, I already spent
> too much time on this, so out it goes. Lightly tested.
>
> Regardless, I *will* make time for ripping the feature out if we
> decide to do that. Quick & easy way to avoid reviewing this series
> *hint* *hint*.
Apart from the nits pointed out in patch 7 (commit message) and 8 (code),
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks, and don't forget to fix the hole that your head has left in the
wall.
Paolo
next prev parent reply other threads:[~2020-10-29 18:07 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 13:38 [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp Markus Armbruster
2020-10-29 13:38 ` [PATCH 01/11] test-util-sockets: Plug file descriptor leak Markus Armbruster
2020-10-29 17:59 ` Eric Blake
2020-10-29 13:38 ` [PATCH 02/11] test-util-sockets: Correct to set has_abstract, has_tight Markus Armbruster
2020-10-29 18:36 ` Eric Blake
2020-10-29 13:38 ` [PATCH 03/11] test-util-sockets: Clean up SocketAddress construction Markus Armbruster
2020-10-29 18:43 ` Eric Blake
2020-10-30 9:36 ` Daniel P. Berrangé
2020-10-30 14:06 ` Markus Armbruster
2020-10-29 13:38 ` [PATCH 04/11] test-util-sockets: Factor out test_socket_unix_abstract_one() Markus Armbruster
2020-10-29 18:52 ` Eric Blake
2020-10-29 13:38 ` [PATCH 05/11] test-util-sockets: Synchronize properly, don't sleep(1) Markus Armbruster
2020-10-29 18:54 ` Eric Blake
2020-10-30 6:40 ` Markus Armbruster
2020-10-29 13:38 ` [PATCH 06/11] test-util-sockets: Test the complete abstract socket matrix Markus Armbruster
2020-10-29 19:19 ` Eric Blake
2020-10-30 9:33 ` Daniel P. Berrangé
2020-10-30 14:14 ` Markus Armbruster
2020-10-29 13:38 ` [PATCH 07/11] sockets: Fix default of UnixSocketAddress member @tight Markus Armbruster
2020-10-29 17:39 ` Paolo Bonzini
2020-10-29 18:05 ` Paolo Bonzini
2020-10-30 6:58 ` Markus Armbruster
2020-10-29 19:34 ` Eric Blake
2020-10-30 6:54 ` Markus Armbruster
2020-10-29 13:38 ` [PATCH 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets Markus Armbruster
2020-10-29 17:47 ` Paolo Bonzini
2020-10-30 8:56 ` Markus Armbruster
2020-10-29 19:38 ` Eric Blake
2020-10-30 9:04 ` Markus Armbruster
2020-10-30 12:39 ` Eric Blake
2020-10-29 13:38 ` [PATCH 09/11] char-socket: Fix qemu_chr_socket_address() " Markus Armbruster
2020-10-29 19:41 ` Eric Blake
2020-10-30 9:09 ` Markus Armbruster
2020-10-29 13:38 ` [PATCH 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets Markus Armbruster
2020-10-29 19:42 ` Eric Blake
2020-10-29 13:38 ` [PATCH 11/11] sockets: Make abstract UnixSocketAddress depend on CONFIG_LINUX Markus Armbruster
2020-10-29 19:54 ` Eric Blake
2020-10-30 9:25 ` Markus Armbruster
2020-10-29 13:53 ` [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp Marc-André Lureau
2020-10-30 10:11 ` Markus Armbruster
2020-10-30 10:20 ` Daniel P. Berrangé
2020-11-02 8:44 ` Markus Armbruster
2020-11-02 8:57 ` Paolo Bonzini
2020-11-02 9:18 ` Daniel P. Berrangé
2020-11-02 9:59 ` Markus Armbruster
2020-11-02 10:02 ` Daniel P. Berrangé
2020-11-02 11:58 ` Markus Armbruster
2020-10-29 18:06 ` Paolo Bonzini [this message]
2020-10-30 10:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07eb80c1-6d56-2bd4-c8be-90a34167ae91@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zxq_yx_007@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).