From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 4/7] m68k: add an interrupt controller
Date: Mon, 25 Jan 2021 12:56:19 +0100 [thread overview]
Message-ID: <07f0985b-fa01-f0f9-fb4c-ff1e413a8d54@vivier.eu> (raw)
In-Reply-To: <32a18f3f-4cf1-d12d-9ff1-5a70adcf09cf@amsat.org>
Le 24/01/2021 à 17:46, Philippe Mathieu-Daudé a écrit :
> On 12/20/20 12:26 PM, Laurent Vivier wrote:
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>> include/hw/intc/m68k_irqc.h | 28 +++++++++
>> hw/intc/m68k_irqc.c | 120 ++++++++++++++++++++++++++++++++++++
>
> Missing MAINTAINERS entries?
new devices are added in patch 7 (where I add the machine and the section in MAINTAINER), but I've
missed this one. Thanks.
>
>> hw/intc/Kconfig | 3 +
>> hw/intc/meson.build | 1 +
>> 4 files changed, 152 insertions(+)
>> create mode 100644 include/hw/intc/m68k_irqc.h
>> create mode 100644 hw/intc/m68k_irqc.c
>>
>> diff --git a/include/hw/intc/m68k_irqc.h b/include/hw/intc/m68k_irqc.h
>> new file mode 100644
>> index 000000000000..c40b1b4df8fa
>> --- /dev/null
>> +++ b/include/hw/intc/m68k_irqc.h
>> @@ -0,0 +1,28 @@
>> +/*
>> + * SPDX-License-Identifer: GPL-2.0-or-later
>> + *
>> + * QEMU Motorla 680x0 IRQ Controller
>
> Typo "Motorola".
Thank you (there is another typo: "q800_irq_register_types" that must be renamed)
> Are there any specs to refer at?
>
There is no specs. It's a (generic) copy of the GLUE device we already have for q800.
I don't update Q800 because the GLUE device may disappear because Q800 uses actually djMEMC that is
also a memory controller (I have that in my q800-dev branch, but for the moment it's only needed for
the MacROM and Mark is working on that).
Thanks,
Laurent
next prev parent reply other threads:[~2021-01-25 11:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 11:26 [PATCH v2 0/7] m68k: add Virtual M68k Machine Laurent Vivier
2020-12-20 11:26 ` [PATCH v2 1/7] m68k: import bootinfo headers from linux Laurent Vivier
2020-12-20 11:26 ` [PATCH v2 2/7] char: add goldfish-tty Laurent Vivier
2021-01-24 0:13 ` Philippe Mathieu-Daudé
2020-12-20 11:26 ` [PATCH v2 3/7] intc: add goldfish-pic Laurent Vivier
2021-01-24 0:08 ` Philippe Mathieu-Daudé
2020-12-20 11:26 ` [PATCH v2 4/7] m68k: add an interrupt controller Laurent Vivier
2021-01-24 16:46 ` Philippe Mathieu-Daudé
2021-01-25 11:56 ` Laurent Vivier [this message]
2021-02-12 18:44 ` Philippe Mathieu-Daudé
2020-12-20 11:26 ` [PATCH v2 5/7] m68k: add a system controller Laurent Vivier
2020-12-20 11:26 ` [PATCH v2 6/7] goldfish_rtc: re-arm the alarm after migration Laurent Vivier
2021-01-23 15:05 ` Laurent Vivier
2021-01-25 23:44 ` Alistair Francis
2021-02-06 14:46 ` Laurent Vivier
2021-02-09 1:49 ` Alistair Francis
2021-01-24 0:15 ` Philippe Mathieu-Daudé
2020-12-20 11:26 ` [PATCH v2 7/7] m68k: add Virtual M68k Machine Laurent Vivier
2021-01-24 0:18 ` Philippe Mathieu-Daudé
2021-01-24 10:58 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f0985b-fa01-f0f9-fb4c-ff1e413a8d54@vivier.eu \
--to=laurent@vivier.eu \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).