From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v6 0/5] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers
Date: Wed, 19 May 2021 17:39:08 -0400 [thread overview]
Message-ID: <07fb087d-38dd-15ce-b04f-2dbc06a103e4@redhat.com> (raw)
In-Reply-To: <20210519163448.2154339-1-philmd@redhat.com>
On 5/19/21 12:34 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> The floppy disc controllers pulls in irrelevant devices (sysbus in
> an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
>
> This series clean that by extracting each device in its own file,
> adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.
>
> Since v5:
> - Added stub (thuth)
>
> Since v4:
> - Dropped machine patches for later due to DMA jazz issue
>
> Since v3:
> - Fix ISA_SUPERIO -> FDC Kconfig dependency (jsnow)
>
> Since v2:
> - rebased
>
> Since v1:
> - added missing "hw/block/block.h" header (jsnow)
> - inlined hardware specific calls (Mark)
> - added R-b/A-b tags
>
> Regards,
>
> Phil.
>
Tentatively staged to floppy branch again.
Allowing Paolo/Thomas et al a chance to reject 01/05 it before sending a PR.
(I am also, unrelatedly, waiting on PJP to send more patches for FDC and
I will collect all the FDC patches together and send. Thanks!)
--js
next prev parent reply other threads:[~2021-05-19 21:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 16:34 [PATCH v6 0/5] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers Philippe Mathieu-Daudé
2021-05-19 16:34 ` [PATCH v6 1/5] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC Philippe Mathieu-Daudé
2021-05-20 7:14 ` Thomas Huth
2021-05-19 16:34 ` [PATCH v6 2/5] hw/block/fdc: Replace disabled fprintf() by trace event Philippe Mathieu-Daudé
2021-05-19 16:34 ` [PATCH v6 3/5] hw/block/fdc: Declare shared prototypes in fdc-internal.h Philippe Mathieu-Daudé
2021-05-19 16:34 ` [PATCH v6 4/5] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c Philippe Mathieu-Daudé
2021-05-19 16:34 ` [PATCH v6 5/5] hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c Philippe Mathieu-Daudé
2021-05-19 21:39 ` John Snow [this message]
2021-05-20 9:59 ` [PATCH v6 0/5] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07fb087d-38dd-15ce-b04f-2dbc06a103e4@redhat.com \
--to=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).