From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goQIi-0003Zt-GX for qemu-devel@nongnu.org; Tue, 29 Jan 2019 05:07:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goQIh-000609-Os for qemu-devel@nongnu.org; Tue, 29 Jan 2019 05:07:28 -0500 References: <20190128170819.4998232d.cohuck@redhat.com> <1548754934-6031-1-git-send-email-thuth@redhat.com> <20190129104944.138d4b4b.cohuck@redhat.com> From: Paolo Bonzini Message-ID: <07fb3b7d-516f-3e2c-a992-9ced6ce90e40@redhat.com> Date: Tue, 29 Jan 2019 11:07:19 +0100 MIME-Version: 1.0 In-Reply-To: <20190129104944.138d4b4b.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x: express dependencies with Kconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Thomas Huth Cc: qemu-devel@nongnu.org, yang.zhong@intel.com, qemu-s390x@nongnu.org On 29/01/19 10:49, Cornelia Huck wrote: > On Tue, 29 Jan 2019 10:42:14 +0100 > Thomas Huth wrote: > >> Instead of hard-coding all config switches in the config file >> default-configs/s390x-softmmu.mak, let's use the new Kconfig files >> to express the necessary dependencies: The S390_CCW_VIRTIO config switch >> for the "s390-ccw-virtio" machine now selects all non-optional devices. >> >> And since we already have the VIRTIO_PCI and VIRTIO_MMIO config switches >> for the other two virtio transports, this patch also introduces a new >> config switch VIRTIO_CCW for the third, s390x-specific virtio transport, >> so that all three virtio transports are now handled in the same way. >> >> Signed-off-by: Thomas Huth >> --- >> v2: >> - Use CONFIG_TERMINAL3270 for 3270-ccw.o >> - Use CONFIG_VIRTIO_CCW for all related devices in the Makefile >> >> default-configs/s390x-softmmu.mak | 12 ++++++++---- >> hw/s390x/Kconfig | 4 ++++ >> hw/s390x/Makefile.objs | 4 +++- >> hw/virtio/Kconfig | 4 ++++ >> 4 files changed, 19 insertions(+), 5 deletions(-) > > Looks sane to me. > > As I have not looked into the Kconfig infrastructure, I don't feel > comfortable enough to give a R-b, but have a > > Acked-by: Cornelia Huck > Thanks. Yang, can you integrate it into the next version? Paolo