From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH 1/2] keyval: accept escaped commas in implied option
Date: Wed, 11 Nov 2020 12:05:51 +0100 [thread overview]
Message-ID: <0803bf79-da12-18db-7c5e-5cdbd02ce804@redhat.com> (raw)
In-Reply-To: <20201111105353.GE906488@redhat.com>
On 11/11/20 11:53, Daniel P. Berrangé wrote:
> On Wed, Nov 11, 2020 at 05:45:20AM -0500, Paolo Bonzini wrote:
>> This is used with the weirdly-named device "SUNFD,two", so accepting it
>> is also a preparatory step towards keyval-ifying -device and the
>> device_add monitor command. But in general it is an unexpected wart
>> of the keyval syntax and leads to suboptimal errors compared to QemuOpts:
>
> If "SUNFD,two" is the only wierdly named device, can we just rename
> it to get rid of the comma, and then put validation in QOM to forbid
> commas entirely. eg rename it to "SUNFD-two"
>
> Just have a targetted hack in vl.c to replace any use of "SUNFD,two"
> with the new name before parsing in keyval, if we care enough about
> back compat for this niche hardware device.
See the rest of the commit message. The patch improves error messages
as a side effect, and in my opinion also the code. So it can be
considered independent of the original reason why it was developed.
Paolo
next prev parent reply other threads:[~2020-11-11 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 10:45 [PATCH 0/2] keyval: accept escaped commas in implied option Paolo Bonzini
2020-11-11 10:45 ` [PATCH 1/2] " Paolo Bonzini
2020-11-11 10:53 ` Daniel P. Berrangé
2020-11-11 11:05 ` Paolo Bonzini [this message]
2020-11-11 11:14 ` Mark Cave-Ayland
2020-11-27 8:38 ` Markus Armbruster
2020-11-27 9:15 ` Paolo Bonzini
2020-11-27 14:39 ` Markus Armbruster
2020-11-27 15:39 ` Paolo Bonzini
2020-11-11 10:45 ` [PATCH 2/2] keyval: simplify keyval_parse_one Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0803bf79-da12-18db-7c5e-5cdbd02ce804@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).