From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
Pierrick Bouvier <pierrick.bouvier@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Anton Johansson <anjo@rev.ng>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH 3/5] accel/tcg: Take mmap lock in the whole cpu_memory_rw_debug() function
Date: Mon, 17 Feb 2025 11:37:10 -0800 [thread overview]
Message-ID: <0806849b-2e20-48e5-b447-3fcaff49bfd8@linaro.org> (raw)
In-Reply-To: <20250217130610.18313-4-philmd@linaro.org>
On 2/17/25 05:06, Philippe Mathieu-Daudé wrote:
> Simplify user implementation of cpu_memory_rw_debug() by
> taking the mmap lock globally. See commit 87ab2704296
> ("linux-user: Allow gdbstub to ignore page protection")
> for why this lock is necessary.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> cpu-target.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2025-02-17 19:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 13:06 [PATCH 0/5] accel/tcg: Clean cpu_memory_rw_debug() up Philippe Mathieu-Daudé
2025-02-17 13:06 ` [PATCH 1/5] accel/accel-cpu-target.h: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2025-02-17 13:06 ` [PATCH 2/5] accel/tcg: Include missing bswap headers in user-exec.c Philippe Mathieu-Daudé
2025-02-17 19:36 ` Richard Henderson
2025-02-17 13:06 ` [PATCH 3/5] accel/tcg: Take mmap lock in the whole cpu_memory_rw_debug() function Philippe Mathieu-Daudé
2025-02-17 19:37 ` Richard Henderson [this message]
2025-02-17 13:06 ` [PATCH 4/5] accel/tcg: Avoid using lock_user() in cpu_memory_rw_debug() Philippe Mathieu-Daudé
2025-02-17 19:39 ` Richard Henderson
2025-02-17 13:06 ` [PATCH 5/5] accel/tcg: Move cpu_memory_rw_debug() user implementation to user-exec.c Philippe Mathieu-Daudé
2025-02-17 19:40 ` Richard Henderson
2025-02-20 15:28 ` [PATCH 0/5] accel/tcg: Clean cpu_memory_rw_debug() up Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0806849b-2e20-48e5-b447-3fcaff49bfd8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anjo@rev.ng \
--cc=iii@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).