From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B83EC47DDF for ; Fri, 26 Jan 2024 15:43:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTOMY-0001Xo-O5; Fri, 26 Jan 2024 10:43:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTOMX-0001XE-Bi for qemu-devel@nongnu.org; Fri, 26 Jan 2024 10:43:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTOMV-0000D1-PG for qemu-devel@nongnu.org; Fri, 26 Jan 2024 10:43:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706283802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RMDE0NvbhTOGDGYd0eCsQIpz3BCgKWlEV8Ygln5FJk4=; b=b4PuQErmI0oznXB4NnCLmhW8yQBssQ/UralApED+sPC9/aec6epqnBEFePQULtLV/ua6zf 3LWBBLCxtkiD9EM9TST+EHR4yz6zSRvUJDO5pIxmPtyWY30DyUsuUjHgGdh/bjowEm61U0 /7QJKn4i4G7GAEfX+yK9+7NCSCllbso= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-4kkyyDnNPFazbew2RVD3qg-1; Fri, 26 Jan 2024 10:43:20 -0500 X-MC-Unique: 4kkyyDnNPFazbew2RVD3qg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6868e2ed965so6026726d6.2 for ; Fri, 26 Jan 2024 07:43:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706283800; x=1706888600; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RMDE0NvbhTOGDGYd0eCsQIpz3BCgKWlEV8Ygln5FJk4=; b=PToN/K1whsBpinkxZpeQMifhXDkGuaSGuFvrDdnfAhye2H55uThOY0XSbcT2ANAWXj +ciFfaQ5IfFzm3ZgHGDo2Htot/t0m6si/t5tPInD/qL/VIaimliy90q5vsXmaJMAJ3ut qLtEp4jAemSa0eJ1SlS6kQqFDPYuTv8Js0VlIpMBfiK2vyBXKf0wTbhYsn6QwAXlOw99 5zsEENT89d9IYNe33V4KSfE9srz1LvVZBagnQzTxaJa9jiMEl0w5dfep1fjOP9Ykvp4/ heQ7KCVdL7XdGPWsXKuIAfMbNjULhgpj0zjjpAtXnTepiBTKja2RqZd68fmPjPkLvEFT t4bg== X-Gm-Message-State: AOJu0YxsuVbUPJ+ymm6V1Pt1DJvqdpm9EtrdwQY1KnQ6acHmf2sYpfuS CTB0NQnXVyurBLMDnejOT9oQui6v85r9LIUI/SkgrKyBHKhJIbsSZLEX+vltMyQyYsipYvlR48D W0U98E90g/zHsc1bjzNQ/rKXVuQB/BftpcHHjPAhoAK6hrpnRwyA+ X-Received: by 2002:ac8:7d52:0:b0:42a:7fd6:c41a with SMTP id h18-20020ac87d52000000b0042a7fd6c41amr26212qtb.25.1706283800160; Fri, 26 Jan 2024 07:43:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwuXkEqM+dO2mAU6yEmoyoCZc51ja30CrvVEi5iPDFMioB4ZA3fo9o4GrXEuhsqhiX9vLYIw== X-Received: by 2002:ac8:7d52:0:b0:42a:7fd6:c41a with SMTP id h18-20020ac87d52000000b0042a7fd6c41amr26203qtb.25.1706283799901; Fri, 26 Jan 2024 07:43:19 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-176-119.web.vodafone.de. [109.43.176.119]) by smtp.gmail.com with ESMTPSA id cm5-20020a05622a250500b00429d6bd085csm623206qtb.6.2024.01.26.07.43.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 07:43:19 -0800 (PST) Message-ID: <08069886-c266-4101-a6e0-6fa8137a313c@redhat.com> Date: Fri, 26 Jan 2024 16:43:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/10] m68k: Clean up includes Content-Language: en-US To: Peter Maydell , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org References: <20240125163408.1595135-1-peter.maydell@linaro.org> <20240125163408.1595135-7-peter.maydell@linaro.org> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240125163408.1595135-7-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.313, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 25/01/2024 17.34, Peter Maydell wrote: > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git m68k include/hw/audio/asc.h include/hw/m68k/*.h > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell > --- > include/hw/audio/asc.h | 1 - > include/hw/m68k/q800-glue.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/include/hw/audio/asc.h b/include/hw/audio/asc.h > index 4741f92c461..04fac270b6a 100644 > --- a/include/hw/audio/asc.h > +++ b/include/hw/audio/asc.h > @@ -13,7 +13,6 @@ > #ifndef HW_AUDIO_ASC_H > #define HW_AUDIO_ASC_H > > -#include "qemu/osdep.h" > #include "hw/sysbus.h" > #include "audio/audio.h" > > diff --git a/include/hw/m68k/q800-glue.h b/include/hw/m68k/q800-glue.h > index ceb916d16c1..04fac25f6c2 100644 > --- a/include/hw/m68k/q800-glue.h > +++ b/include/hw/m68k/q800-glue.h > @@ -23,7 +23,6 @@ > #ifndef HW_Q800_GLUE_H > #define HW_Q800_GLUE_H > > -#include "qemu/osdep.h" > #include "hw/sysbus.h" > > #define TYPE_GLUE "q800-glue" Reviewed-by: Thomas Huth