From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWhMg-0003ct-SD for qemu-devel@nongnu.org; Mon, 08 Aug 2016 06:00:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWhMc-0001z1-1e for qemu-devel@nongnu.org; Mon, 08 Aug 2016 06:00:58 -0400 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:36155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWhMb-0001yt-RT for qemu-devel@nongnu.org; Mon, 08 Aug 2016 06:00:53 -0400 Received: by mail-pa0-x232.google.com with SMTP id pp5so112541386pac.3 for ; Mon, 08 Aug 2016 03:00:53 -0700 (PDT) Sender: Richard Henderson References: <20160807014121.18739-1-bobby.prani@gmail.com> <31b8d7c7-6a5c-910f-b799-25a8e00c8908@redhat.com> <561336e2-41b3-d2a8-600e-e777747cac62@redhat.com> From: Richard Henderson Message-ID: <080c7421-c46d-f98a-5a38-7ad6eaf6bd35@twiddle.net> Date: Mon, 8 Aug 2016 15:30:41 +0530 MIME-Version: 1.0 In-Reply-To: <561336e2-41b3-d2a8-600e-e777747cac62@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] seqlock: Fix warning reg. incompatible cast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Pranith Kumar , "Emilio G. Cota" , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Sergey Fedorov , Markus Armbruster , "open list:All patches CC here" On 08/08/2016 03:25 PM, Paolo Bonzini wrote: > + __builtin_choose_expr( \ > + __builtin_types_compatible_p(typeof(expr), const char) || \ > + __builtin_types_compatible_p(typeof(expr), char), \ > + (char)1, \ Better as signed char, since bare char could be either signed or unsigned. r~